deprecation: Add SDK Version in deprecation warning

Author: mufaddal-rohawala

src/sagemaker/deprecations.py

@@ -21,24 +21,27 @@
 V2_URL = "https://sagemaker.readthedocs.io/en/stable/v2.html"
 
 
-def _warn(msg):
+def _warn(msg, sdk_version=None):
     """Generic warning raiser referencing V2
 
     Args:
         phrase: The phrase to include in the warning.
+        sdk_version: the sdk version of removal of support.
     """
-    full_msg = f"{msg} in sagemaker>=2.\nSee: {V2_URL} for details."
+    _sdk_version = sdk_version if sdk_version is not None else "2"
+    full_msg = f"{msg} in sagemaker>={_sdk_version}.\nSee: {V2_URL} for details."
     warnings.warn(full_msg, DeprecationWarning, stacklevel=2)
     logger.warning(full_msg)
 
 
-def removed_warning(phrase):
+def removed_warning(phrase, sdk_version=None):
     """Raise a warning for a no-op in sagemaker>=2
 
     Args:
         phrase: the prefix phrase of the warning message.
+        sdk_version: the sdk version of removal of support.
     """
-    _warn(f"{phrase} is a no-op")
+    _warn(f"{phrase} is a no-op", sdk_version)
 
 
 def renamed_warning(phrase):
@@ -146,26 +149,32 @@ def func(*args, **kwargs):  # pylint: disable=W0613
     return func
 
 
-def deprecated(obj):
+def deprecated(sdk_version=None):
     """Decorator for raising deprecated warning for a feature in sagemaker>=2
 
+    Args:
+        sdk_version (str): the sdk version of removal of support.
+
     Usage:
-        @deprecated
+        @deprecated()
         def sample_function():
             print("xxxx....")
 
-        @deprecated
+        @deprecated(sdk_version="2.66")
         class SampleClass():
             def __init__(self):
                 print("xxxx....")
 
     """
 
-    def wrapper(*args, **kwargs):
-        removed_warning(obj.__name__)
-        return obj(*args, **kwargs)
+    def deprecate(obj):
+        def wrapper(*args, **kwargs):
+            removed_warning(obj.__name__, sdk_version)
+            return obj(*args, **kwargs)
+
+        return wrapper
 
-    return wrapper
+    return deprecate
 
 
 def deprecated_function(func, name):

src/sagemaker/serverless/model.py

@@ -15,9 +15,9 @@
 from sagemaker.deprecations import deprecated
 
 
-@deprecated
+@deprecated(sdk_version="v2.66.3")
 class LambdaModel:
     """A model that can be deployed to Lambda.
 
-    note:: Deprecated in versions > v2.66.0. An alternative support will be added in near future.
+    note:: Deprecated in versions >= v2.66.3. An alternative support will be added in near future.
     """

src/sagemaker/serverless/predictor.py

@@ -15,9 +15,9 @@
 from sagemaker.deprecations import deprecated
 
 
-@deprecated
+@deprecated(sdk_version="v2.66.3")
 class LambdaPredictor:
     """A deployed model hosted on Lambda.
 
-    note:: Deprecated in versions > v2.66.0. An alternative support will be added in near future.
+    note:: Deprecated in versions >= v2.66.3. An alternative support will be added in near future.
     """

tests/unit/sagemaker/serverless/test_model.py

@@ -20,7 +20,7 @@ def test_deprecated_for_class_lamda_model():
     with pytest.warns(DeprecationWarning) as w:
         LambdaModel()
         msg = (
-            "LambdaModel is a no-op in sagemaker>=2.\n"
+            "LambdaModel is a no-op in sagemaker>=v2.66.3.\n"
             "See: https://sagemaker.readthedocs.io/en/stable/v2.html for details."
         )
         assert str(w[-1].message) == msg

tests/unit/sagemaker/serverless/test_predictor.py

@@ -22,7 +22,7 @@ def test_deprecated_for_class_lamda_predictor():
     with pytest.warns(DeprecationWarning) as w:
         LambdaPredictor()
         msg = (
-            "LambdaPredictor is a no-op in sagemaker>=2.\n"
+            "LambdaPredictor is a no-op in sagemaker>=v2.66.3.\n"
             "See: https://sagemaker.readthedocs.io/en/stable/v2.html for details."
         )
         assert str(w[-1].message) == msg

tests/unit/test_deprecations.py

@@ -113,7 +113,7 @@ def sample_method(self):
 
 
 def test_deprecated_for_function():
-    @deprecated
+    @deprecated()
     def sample_function():
         return "xxxx...."
 
@@ -128,15 +128,15 @@ def sample_function():
 
 
 def test_deprecated_for_class():
-    @deprecated
+    @deprecated(sdk_version="2.66.6")
     class SampleClass:
         def __init__(self):
             pass
 
     with pytest.warns(DeprecationWarning) as w:
         SampleClass()
         msg = (
-            "SampleClass is a no-op in sagemaker>=2.\n"
+            "SampleClass is a no-op in sagemaker>=2.66.6.\n"
             "See: https://sagemaker.readthedocs.io/en/stable/v2.html for details."
         )
         assert str(w[-1].message) == msg
@@ -147,7 +147,7 @@ class SampleClass:
         def __init__(self):
             pass
 
-        @deprecated
+        @deprecated()
         def sample_method(self):
             return "xxxx...."