Use script mode in 1.13 and older

Author: icywang86rui

src/sagemaker/tensorflow/estimator.py

@@ -278,12 +278,12 @@ def _validate_args(self, py_version, script_mode, framework_version, training_st
                     .format(', '.join(_FRAMEWORK_MODE_ARGS), ', '.join(found_args))
                 )
 
-        if (not self._script_mode_enabled()) and \
-           [int(s) for s in self.framework_version.split('.')] >= self._LOWEST_SCRIPT_MODE_ONLY_VERSION:
-            raise AttributeError(
-                'Legacy mode is deprecated in versions 1.13 and higher.'
-                'Please set the script_mode argument to True to use Script Mode'
-            )
+        if (not self._script_mode_enabled()) and self._only_script_mode_supported():
+            logger.warning('Legacy mode is deprecated in versions 1.13 and higher. Using script mode instead.')
+            self.script_mode = True
+
+    def _only_script_mode_supported(self):
+        return [int(s) for s in self.framework_version.split('.')] >= self._LOWEST_SCRIPT_MODE_ONLY_VERSION
 
     def _validate_requirements_file(self, requirements_file):
         if not requirements_file:

tests/unit/test_tf_estimator.py

@@ -738,11 +738,10 @@ def test_script_mode_deprecated_args(sagemaker_session):
     assert _deprecated_args_msg('training_steps, evaluation_steps, requirements_file, checkpoint_path') in str(e.value)
 
 
-def test_legacy_mode_deprecation_error(sagemaker_session):
-    with pytest.raises(AttributeError) as e:
-        _build_tf(sagemaker_session=sagemaker_session, framework_version='1.13.1',
-                  py_version='py2', script_mode=False)
-    assert 'Legacy mode is deprecated' in str(e.value)
+def test_legacy_mode_deprecated(sagemaker_session):
+    tf = _build_tf(sagemaker_session=sagemaker_session, framework_version='1.13.1',
+                   py_version='py2', script_mode=False)
+    assert tf._script_mode_enabled() is True
 
 
 def test_script_mode_enabled(sagemaker_session):

tox.ini

@@ -57,7 +57,7 @@ passenv =
 commands =
     coverage run --source sagemaker -m pytest {posargs}
     {env:IGNORE_COVERAGE:} coverage report --fail-under=90 --omit */tensorflow/tensorflow_serving/*
-deps = .[test]
+extras = test
 
 [testenv:flake8]
 basepython = python3