skip test for p2 instance for TF2.12 and above (#3812)

Author: tejaschumbalkar

tests/conftest.py

@@ -52,10 +52,6 @@
     "me-south-1",
     "sa-east-1",
     "us-west-1",
-    "ap-northeast-1",  # it has p3, but not enough
-    "ap-south-1",
-    "ap-northeast-2",  # it has p3, but not enough
-    "us-east-2",  # it has p3, but not enough
 ]
 
 NO_T2_REGIONS = ["eu-north-1", "ap-east-1", "me-south-1"]

tests/integ/test_horovod.py

@@ -24,6 +24,8 @@
 from sagemaker.tensorflow import TensorFlow
 from tests.integ import timeout
 
+from packaging.version import Version
+
 horovod_dir = os.path.join(os.path.dirname(__file__), "..", "data", "horovod")
 
 
@@ -58,6 +60,12 @@ def test_hvd_gpu(
     tmpdir,
     **kwargs,
 ):
+    if (
+        Version(tensorflow_training_latest_version) >= Version("2.12")
+        and kwargs["instance_type"] == "ml.p2.xlarge"
+    ):
+        pytest.skip("P2 instances have been deprecated for sagemaker jobs starting TensorFlow 2.12")
+
     _create_and_fit_estimator(
         sagemaker_session,
         tensorflow_training_latest_version,

tests/integ/test_tf.py

@@ -28,6 +28,7 @@
 from tests.integ.utils import gpu_list, retry_with_instance_list
 from tests.integ.s3_utils import assert_s3_file_patterns_exist
 
+from packaging.version import Version
 
 ROLE = "SageMakerRole"
 
@@ -56,6 +57,12 @@ def test_framework_processing_job_with_deps(
     tensorflow_training_latest_py_version,
     **kwargs,
 ):
+    if (
+        Version(tensorflow_training_latest_version) >= Version("2.12")
+        and kwargs["instance_type"] == "ml.p2.xlarge"
+    ):
+        pytest.skip("P2 instances have been deprecated for sagemaker jobs starting TensorFlow 2.12")
+
     with timeout.timeout(minutes=TRAINING_DEFAULT_TIMEOUT_MINUTES):
         code_path = os.path.join(DATA_DIR, "dummy_code_bundle_with_reqs")
         entry_point = "main_script.py"
@@ -187,6 +194,12 @@ def test_mwms_gpu(
     capsys,
     **kwargs,
 ):
+    if (
+        Version(tensorflow_training_latest_version) >= Version("2.12")
+        and kwargs["instance_type"] == "ml.p2.xlarge"
+    ):
+        pytest.skip("P2 instances have been deprecated for sagemaker jobs starting TensorFlow 2.12")
+
     instance_count = 2
     estimator = TensorFlow(
         source_dir=os.path.join(RESOURCE_PATH, "tensorflow_mnist"),
@@ -243,6 +256,12 @@ def test_mnist_distributed_gpu(
     tensorflow_training_latest_py_version,
     **kwargs,
 ):
+    if (
+        Version(tensorflow_training_latest_version) >= Version("2.12")
+        and kwargs["instance_type"] == "ml.p2.xlarge"
+    ):
+        pytest.skip("P2 instances have been deprecated for sagemaker jobs starting TensorFlow 2.12")
+
     _create_and_fit_estimator(
         sagemaker_session,
         tensorflow_training_latest_version,