modified warning msg

Author: Yue Tu

src/sagemaker/git_utils.py

@@ -145,36 +145,30 @@ def _clone_command_for_github_like(git_config, dest_dir):
 
 def _clone_command_for_github_like_ssh(git_config, dest_dir):
     if "username" in git_config or "password" in git_config or "token" in git_config:
-        warnings.warn("Unnecessary credential argument(s) provided.")
+        warnings.warn("SSH cloning, authentication information in git config will be ignored.")
     _run_clone_command(git_config["repo"], dest_dir)
 
 
 def _clone_command_for_github_like_https_2fa_disabled(git_config, dest_dir):
     updated_url = git_config["repo"]
     if "token" in git_config:
         if "username" in git_config or "password" in git_config:
-            warnings.warn(
-                "Using token for authentication, "
-                "but unnecessary credential argument(s) provided."
-            )
+            warnings.warn("Using token for authentication, " "other credentials will be ignored.")
         updated_url = _insert_token_to_repo_url(url=git_config["repo"], token=git_config["token"])
     elif "username" in git_config and "password" in git_config:
         updated_url = _insert_username_and_password_to_repo_url(
             url=git_config["repo"], username=git_config["username"], password=git_config["password"]
         )
     elif "username" in git_config or "password" in git_config:
-        warnings.warn("Unnecessary credential argument(s) provided.")
+        warnings.warn("Credentials provided in git config will be ignored.")
     _run_clone_command(updated_url, dest_dir)
 
 
 def _clone_command_for_github_like_https_2fa_enabled(git_config, dest_dir):
     updated_url = git_config["repo"]
     if "token" in git_config:
         if "username" in git_config or "password" in git_config:
-            warnings.warn(
-                "Using token for authentication, "
-                "but unnecessary credential argument(s) provided."
-            )
+            warnings.warn("Using token for authentication, " "other credentials will be ignored.")
         updated_url = _insert_token_to_repo_url(url=git_config["repo"], token=git_config["token"])
     _run_clone_command(updated_url, dest_dir)
 

tests/unit/test_git_utils.py

@@ -298,7 +298,7 @@ def test_git_clone_repo_with_token_no_2fa_unnecessary_creds_provided(isfile, mkd
     with pytest.warns(UserWarning) as warn:
         ret = git_utils.git_clone_repo(git_config=git_config, entry_point=entry_point)
     assert (
-        "Using token for authentication, but unnecessary credential argument(s) provided."
+        "Using token for authentication, other credentials will be ignored."
         in warn[0].message.args[0]
     )
     check_call.assert_any_call(
@@ -334,7 +334,10 @@ def test_git_clone_repo_with_token_2fa_unnecessary_creds_provided(isfile, mkdtem
     env["GIT_TERMINAL_PROMPT"] = "0"
     with pytest.warns(UserWarning) as warn:
         ret = git_utils.git_clone_repo(git_config=git_config, entry_point=entry_point)
-    assert "unnecessary credential argument(s) provided." in warn[0].message.args[0]
+    assert (
+        "Using token for authentication, other credentials will be ignored."
+        in warn[0].message.args[0]
+    )
     check_call.assert_any_call(
         [
             "git",