address PR comments

Author: laurenyu

src/sagemaker/image_uris.py

@@ -78,7 +78,7 @@ def _config_for_framework_and_scope(framework, image_scope, accelerator_type=Non
 
     if accelerator_type:
         if image_scope not in ("eia", "inference"):
-            logger.info(
+            logger.warning(
                 "Elastic inference is for inference only. Ignoring image scope: %s.", image_scope
             )
         image_scope = "eia"
@@ -156,8 +156,4 @@ def _validate_arg(arg_name, arg, available_options):
 
 def _format_tag(version, processor, py_version):
     """Creates a tag for the image URI."""
-    tag = "{}-{}".format(version, processor)
-    if py_version:
-        tag += "-{}".format(py_version)
-
-    return tag
+    return "-".join([x for x in (version, processor, py_version) if x])

tests/unit/sagemaker/image_uris/test_dlc_frameworks.py

@@ -48,9 +48,7 @@
 
 def _expected_uri(repo, fw_version, account, py_version=None, processor="cpu", region=REGION):
     domain = ALTERNATE_DOMAINS.get(region, DOMAIN)
-    tag = "{}-{}".format(fw_version, processor)
-    if py_version:
-        tag = "-".join((tag, py_version))
+    tag = "-".join([x for x in (fw_version, processor, py_version) if x])
 
     return IMAGE_URI_FORMAT.format(account, region, domain, repo, tag)
 

tests/unit/sagemaker/image_uris/test_retrieve.py

@@ -91,7 +91,6 @@ def test_retrieve_eia(config_for_framework, caplog):
     )
     assert "123412341234.dkr.ecr.us-west-2.amazonaws.com/dummy-eia:1.0.0-cpu-py3" == uri
 
-    caplog.set_level(logging.INFO)
     uri = image_uris.retrieve(
         framework="useless-string",
         version="1.0.0",