Skip to content

Fix the 'UnexpectedParameter' when updating the task definition to use Service Connect #4310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fix the 'UnexpectedParameter' when updating the task definition to use Service Connect #4310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eef18d9
Fix AwsEcsTaskDefinitionContainerDefinitionsPortMappingsDetails to su…
veglos Dec 31, 2022
f219d1c
correct version
veglos Dec 31, 2022
3253d6f
merge
veglos Dec 31, 2022
868de85
restore original format
veglos Dec 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/next-release/bugfix-ecs-fe04eed4.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"type": "bugfix",
"category": "ecs",
"description": "adds the missing appProtocol and name parameters to the AwsEcsTaskDefinitionContainerDefinitionsPortMappingsDetails type definition in order to support Service Connect."
}
16 changes: 16 additions & 0 deletions apis/securityhub-2018-10-26.normal.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7364,9 +7364,21 @@
"shape": "AwsEcsTaskDefinitionContainerDefinitionsMountPointsDetails"
}
},
"AppProtocol": {
"type": "string",
"enum": [
"http",
"http2",
"grpc"
]
},
"AwsEcsTaskDefinitionContainerDefinitionsPortMappingsDetails": {
"type": "structure",
"members": {
"AppProtocol": {
"shape": "AppProtocol",
"documentation": "<p>The application protocol that's used for the port mapping. This parameter only applies to Service Connect.</p>"
},
"ContainerPort": {
"shape": "Integer",
"documentation": "<p>The port number on the container that is bound to the user-specified or automatically assigned host port.</p>"
Expand All @@ -7375,6 +7387,10 @@
"shape": "Integer",
"documentation": "<p>The port number on the container instance to reserve for the container.</p>"
},
"Name": {
"shape": "NonEmptyString",
"documentation": "<p>The name that's used for the port mapping. This parameter only applies to Service Connect.</p>"
},
"Protocol": {
"shape": "NonEmptyString",
"documentation": "<p>The protocol used for the port mapping. The default is <code>tcp</code>.</p>"
Expand Down
9 changes: 9 additions & 0 deletions clients/securityhub.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4932,7 +4932,12 @@ declare namespace SecurityHub {
SourceVolume?: NonEmptyString;
}
export type AwsEcsTaskDefinitionContainerDefinitionsMountPointsList = AwsEcsTaskDefinitionContainerDefinitionsMountPointsDetails[];
export type AppProtocol = "http"|"http2"|"grpc"|string;
export interface AwsEcsTaskDefinitionContainerDefinitionsPortMappingsDetails {
/**
* The application protocol that's used for the port mapping. This parameter only applies to Service Connect.
*/
AppProtocol?: AppProtocol;
/**
* The port number on the container that is bound to the user-specified or automatically assigned host port.
*/
Expand All @@ -4941,6 +4946,10 @@ declare namespace SecurityHub {
* The port number on the container instance to reserve for the container.
*/
HostPort?: Integer;
/**
* The name that's used for the port mapping. This parameter only applies to Service Connect.
*/
Name?: NonEmptyString;
/**
* The protocol used for the port mapping. The default is tcp.
*/
Expand Down