Skip to content

Commit 7ea88e6

Browse files
author
Yauheni Sliaptsou
committed
Change default endpoint in config description, add the new probes configuration to the helm readme in the general config section.
1 parent 5830dea commit 7ea88e6

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

config/helm/aws-node-termination-handler/README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,9 @@ Parameter | Description | Default
7474
`logLevel` | Sets the log level (INFO, DEBUG, or ERROR) | `INFO`
7575
`enablePrometheusServer` | If true, start an http server exposing `/metrics` endpoint for prometheus. | `false`
7676
`prometheusServerPort` | Replaces the default HTTP port for exposing prometheus metrics. | `9092`
77+
`enableProbesServer` |If true, start an http server exposing `/healthz` endpoint for probes. | `false`
78+
`probesServerPort` | Replaces the default HTTP port for exposing probes endpoint. | `8080`
79+
`probesServerEndpoint` | Replaces the default endpoint for exposing probes endpoint. | `/healthz`
7780
`podMonitor.create` | if `true`, create a PodMonitor | `false`
7881
`podMonitor.interval` | Prometheus scrape interval | `30s`
7982
`podMonitor.sampleLimit` | Number of scraped samples accepted | `5000`

config/helm/aws-node-termination-handler/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ enablePrometheusServer: false
153153
prometheusServerPort: 9092
154154

155155
enableProbesServer: false
156-
probesServerPort: "8080"
156+
probesServerPort: 8080
157157
probesServerEndpoint: "/healthz"
158158

159159
tolerations:

pkg/config/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ func ParseCliArgs() (config Config, err error) {
172172
flag.StringVar(&config.UptimeFromFile, "uptime-from-file", getEnv(uptimeFromFileConfigKey, uptimeFromFileDefault), "If specified, read system uptime from the file path (useful for testing).")
173173
flag.BoolVar(&config.EnablePrometheus, "enable-prometheus-server", getBoolEnv(enablePrometheusConfigKey, enablePrometheusDefault), "If true, a http server is used for exposing prometheus metrics in /metrics endpoint.")
174174
flag.IntVar(&config.PrometheusPort, "prometheus-server-port", getIntEnv(prometheusPortConfigKey, prometheusPortDefault), "The port for running the prometheus http server.")
175-
flag.BoolVar(&config.EnableProbes, "enable-probes-server", getBoolEnv(enableProbesConfigKey, enableProbesDefault), "If true, a http server is used for exposing probes in /probes endpoint.")
175+
flag.BoolVar(&config.EnableProbes, "enable-probes-server", getBoolEnv(enableProbesConfigKey, enableProbesDefault), "If true, a http server is used for exposing probes in /healthz endpoint.")
176176
flag.IntVar(&config.ProbesPort, "probes-server-port", getIntEnv(probesPortConfigKey, probesPortDefault), "The port for running the probes http server.")
177177
flag.StringVar(&config.ProbesEndpoint, "probes-server-endpoint", getEnv(probesEndpointConfigKey, probesEndpointDefault), "If specified, use this endpoint to make liveness probe")
178178
flag.StringVar(&config.AWSRegion, "aws-region", getEnv(awsRegionConfigKey, ""), "If specified, use the AWS region for AWS API calls")

0 commit comments

Comments
 (0)