Merge pull request #25 from kar-rahul-aws/update_unit_tests

kar-rahul-aws · web-flow · commit 27c8ba97f6d2 · 2024-05-24T14:56:17.000+05:30
Fix warning in unit tests and memory check tests
diff --git a/source/MQTTFileDownloader_cbor.c b/source/MQTTFileDownloader_cbor.c
@@ -114,7 +114,7 @@ bool CBOR_Decode_GetStreamResponseMessage( const uint8_t * messageBuffer,
 
     if( CborNoError == cborResult )
     {
-        cborResult = cbor_value_get_int( &value, ( int32_t * ) fileId );
+        cborResult = cbor_value_get_int( &value, ( int * ) fileId );
     }
 
     /* Find the block ID. */
@@ -132,7 +132,7 @@ bool CBOR_Decode_GetStreamResponseMessage( const uint8_t * messageBuffer,
 
     if( CborNoError == cborResult )
     {
-        cborResult = cbor_value_get_int( &value, ( int32_t * ) blockId );
+        cborResult = cbor_value_get_int( &value, ( int * ) blockId );
     }
 
     /* Find the block size. */
@@ -150,7 +150,7 @@ bool CBOR_Decode_GetStreamResponseMessage( const uint8_t * messageBuffer,
 
     if( CborNoError == cborResult )
     {
-        cborResult = cbor_value_get_int( &value, ( int32_t * ) blockSize );
+        cborResult = cbor_value_get_int( &value, ( int * ) blockSize );
     }
 
     /* Find the payload bytes. */
diff --git a/test/unit-test/downloader_utest.c b/test/unit-test/downloader_utest.c
@@ -626,9 +626,9 @@ void test_processReceivedDataBlock_processesCBORBlock( void )
     int32_t fileId = 0;
     int32_t blockId = 0;
     int32_t blockSize = 0;
-    const int32_t expectedFileId = 20;
-    const int32_t expectedBlockId = 30;
-    const int32_t expectedBlockSize = 40;
+    int32_t expectedFileId = 20;
+    int32_t expectedBlockId = 30;
+    int32_t expectedBlockSize = 40;
 
     CBOR_Decode_GetStreamResponseMessage_ExpectAndReturn( ( const uint8_t * ) validCBORMsg, strlen( validCBORMsg ), NULL, NULL, NULL, NULL, NULL, true );
     CBOR_Decode_GetStreamResponseMessage_IgnoreArg_fileId();

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ bool CBOR_Decode_GetStreamResponseMessage( const uint8_t * messageBuffer,`
`114`	`114`
`115`	`115`	`if( CborNoError == cborResult )`
`116`	`116`	`{`
`117`		`- cborResult = cbor_value_get_int( &value, ( int32_t * ) fileId );`
	`117`	`+ cborResult = cbor_value_get_int( &value, ( int * ) fileId );`
`118`	`118`	`}`
`119`	`119`
`120`	`120`	`/* Find the block ID. */`
`@@ -132,7 +132,7 @@ bool CBOR_Decode_GetStreamResponseMessage( const uint8_t * messageBuffer,`
`132`	`132`
`133`	`133`	`if( CborNoError == cborResult )`
`134`	`134`	`{`
`135`		`- cborResult = cbor_value_get_int( &value, ( int32_t * ) blockId );`
	`135`	`+ cborResult = cbor_value_get_int( &value, ( int * ) blockId );`
`136`	`136`	`}`
`137`	`137`
`138`	`138`	`/* Find the block size. */`
`@@ -150,7 +150,7 @@ bool CBOR_Decode_GetStreamResponseMessage( const uint8_t * messageBuffer,`
`150`	`150`
`151`	`151`	`if( CborNoError == cborResult )`
`152`	`152`	`{`
`153`		`- cborResult = cbor_value_get_int( &value, ( int32_t * ) blockSize );`
	`153`	`+ cborResult = cbor_value_get_int( &value, ( int * ) blockSize );`
`154`	`154`	`}`
`155`	`155`
`156`	`156`	`/* Find the payload bytes. */`