Skip to content

Commit 5d38256

Browse files
committed
feat(maintenance): add support for nodejs20.x runtime (#1790)
* feat(maintenance): support nodejs20.x runtime * tests(metrics): fix object ordering in tests * build(testing): bump cdk * build(maintenance): revert aws-cdk-lib to support nodejs14 * tests(maintenance): set runtime with family * chore(docs): patch runtime in cdk * chore(docs): patch runtime in cdk * chore(maintenance): increment version in commons ahead of release
1 parent 9c47362 commit 5d38256

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+216
-241
lines changed

.devcontainer/Dockerfile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,15 @@
11
# See here for image contents: https://github.com/microsoft/vscode-dev-containers/blob/v0.212.0/containers/javascript-node/.devcontainer/base.Dockerfile
22
# [Choice] Node.js version (use -bullseye variants on local arm64/Apple Silicon): 18, 16, 14, 18-bullseye, 16-bullseye, 14-bullseye, 18-buster, 16-buster, 14-buster
3-
ARG VARIANT="18-bullseye"
3+
ARG VARIANT="20-bullseye"
44
FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:0-${VARIANT}
55

66
# This section to install additional OS packages.
77
RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
88
&& apt-get -y install --no-install-recommends bash-completion
99

10+
# Install fnm to manage Node.js versions
11+
RUN curl -fsSL https://fnm.vercel.app/install | bash -s
12+
1013
RUN wget https://github.com/aws/aws-sam-cli/releases/latest/download/aws-sam-cli-linux-x86_64.zip \
1114
&& unzip aws-sam-cli-linux-x86_64.zip -d sam-installation \
1215
&& sudo ./sam-installation/install \

.devcontainer/devcontainer.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,15 @@
88
// Append -bullseye or -buster to pin to an OS version.
99
// Use -bullseye variants on local arm64/Apple Silicon.
1010
"args": {
11-
"VARIANT": "18-bullseye"
11+
"VARIANT": "20-bullseye"
1212
}
1313
},
1414
"customizations": {
1515
// Add the ids of extensions you want installed when the container is created.
1616
"extensions": [
1717
"dbaeumer.vscode-eslint",
1818
"esbenp.prettier-vscode",
19-
"firsttris.vscode-jest-runner",
20-
"amazonwebservices.aws-toolkit-vscode"
19+
"firsttris.vscode-jest-runner"
2120
],
2221
"vscode": {
2322
"git.enableCommitSigning": true

.github/actions/cached-node-modules/action.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
name: 'Cached Node Modules'
22
description: 'A simple action to cache node_modules or install them if they are not cached'
33
inputs:
4-
nodeVersion: # id of input
4+
nodeVersion: # id of input
55
description: 'Node.js version to use in the cache key'
6-
default: '18'
6+
default: '20'
77
build:
88
description: 'Whether to build the packages or not'
99
default: 'true'
@@ -15,6 +15,7 @@ runs:
1515
using: "composite"
1616
steps:
1717
- name: Install npm
18+
# We need to keep this npm version until we drop Node.js 16 support because Node.js 16 doesn't support npm 10
1819
run: npm i -g npm@next-9
1920
shell: bash
2021
- name: Cache node modules

.github/workflows/make-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
- name: Setup NodeJS
2727
uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
2828
with:
29-
node-version: "18"
29+
node-version: "20"
3030
cache: "npm"
3131
- name: Setup auth tokens
3232
run: |

.github/workflows/make-v2-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
- name: Setup NodeJS
2222
uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
2323
with:
24-
node-version: '18'
24+
node-version: '20'
2525
cache: 'npm'
2626
- name: Setup auth tokens
2727
run: |

.github/workflows/publish_layer.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobs:
3939
- name: Setup Node.js
4040
uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
4141
with:
42-
node-version: "18"
42+
node-version: "20"
4343
- name: Setup dependencies
4444
uses: ./.github/actions/cached-node-modules
4545
- name: CDK build

.github/workflows/reusable-publish-docs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ jobs:
4747
- name: Setup NodeJS
4848
uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
4949
with:
50-
node-version: "18"
50+
node-version: "20"
5151
cache: "npm"
5252
- name: Setup dependencies
5353
uses: ./.github/actions/cached-node-modules

.github/workflows/reusable-run-linting-check-and-unit-tests.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
NODE_ENV: dev
1111
strategy:
1212
matrix:
13-
version: [16, 18]
13+
version: [16, 18, 20]
1414
fail-fast: false
1515
steps:
1616
- name: Checkout code
@@ -45,8 +45,8 @@ jobs:
4545
- name: Setup NodeJS
4646
uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
4747
with:
48-
node-version: 18
49-
cache: 'npm'
48+
node-version: 20
49+
cache: "npm"
5050
- name: Setup dependencies
5151
uses: ./.github/actions/cached-node-modules
5252
- name: Run linting
@@ -63,8 +63,8 @@ jobs:
6363
- name: Setup NodeJS
6464
uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
6565
with:
66-
node-version: 18
67-
cache: 'npm'
66+
node-version: 20
67+
cache: "npm"
6868
- name: Setup dependencies
6969
uses: ./.github/actions/cached-node-modules
7070
- name: Run linting
@@ -81,8 +81,8 @@ jobs:
8181
- name: Setup NodeJS
8282
uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
8383
with:
84-
node-version: 18
85-
cache: 'npm'
84+
node-version: 20
85+
cache: "npm"
8686
- name: Setup dependencies
8787
uses: ./.github/actions/cached-node-modules
8888
- name: Run linting

.github/workflows/reusable_deploy_layer_stack.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ jobs:
7171
- name: Setup Node.js
7272
uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
7373
with:
74-
node-version: "18"
74+
node-version: "20"
7575
- name: Setup dependencies
7676
uses: ./.github/actions/cached-node-modules
7777
- name: Download artifact

.github/workflows/run-e2e-tests.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
packages/parameters,
2929
packages/idempotency,
3030
]
31-
version: [16, 18]
31+
version: [16, 18, 20]
3232
arch: [x86_64, arm64]
3333
fail-fast: false
3434
steps:
@@ -53,11 +53,11 @@ jobs:
5353
- name: Setup NodeJS
5454
uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
5555
with:
56-
node-version: ${{ matrix.version }}
56+
node-version: '20'
5757
- name: Setup dependencies
5858
uses: ./.github/actions/cached-node-modules
5959
with:
60-
nodeVersion: ${{ matrix.version }}
60+
nodeVersion: '20'
6161
- name: Setup AWS credentials
6262
uses: aws-actions/configure-aws-credentials@04b98b3f9e85f563fb061be8751a0352327246b0 # v3.0.1
6363
with:

0 commit comments

Comments
 (0)