From bd011de115d46e05079e64bfaf23c1762eb13e13 Mon Sep 17 00:00:00 2001
From: Mark Wubben <mark@novemberborn.net>
Date: Wed, 23 Dec 2020 15:16:25 +0100
Subject: [PATCH] Only create the cache directory when needed

Avoid potential permission issues if we don't use the cache dir anyway,
see <https://github.com/avajs/ava/issues/1128#issuecomment-716745299>.
---
 lib/api.js | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/api.js b/lib/api.js
index 12bf420d3..14d2a7200 100644
--- a/lib/api.js
+++ b/lib/api.js
@@ -111,10 +111,8 @@ class Api extends Emittery {
 			}
 		};
 
-		let cacheDir;
 		let testFiles;
 		try {
-			cacheDir = this._createCacheDir();
 			testFiles = await globs.findTests({cwd: this.options.projectDir, ...apiOptions.globs});
 			if (selectedFiles.length === 0) {
 				selectedFiles = filter.length === 0 ? testFiles : globs.applyTestFileFilter({
@@ -189,7 +187,7 @@ class Api extends Emittery {
 
 			const {providers = []} = this.options;
 			const providerStates = (await Promise.all(providers.map(async ({type, main}) => {
-				const state = await main.compile({cacheDir, files: testFiles});
+				const state = await main.compile({cacheDir: this._createCacheDir(), files: testFiles});
 				return state === null ? null : {type, state};
 			}))).filter(state => state !== null);