Refactor rename method withResponseHandler() to withHandler() with deprecation

Author: rbygrave

client/src/main/java/io/avaje/http/client/DHttpClientRequest.java

@@ -357,7 +357,7 @@ public <T> List<T> list(Class<T> cls) {
 
   @Override
   public <T> Stream<T> stream(Class<T> cls) {
-    final HttpResponse<Stream<String>> res = withResponseHandler(HttpResponse.BodyHandlers.ofLines());
+    final HttpResponse<Stream<String>> res = withHandler(HttpResponse.BodyHandlers.ofLines());
     this.httpResponse = res;
     if (res.statusCode() >= 300) {
       throw new HttpException(res, context);
@@ -367,7 +367,7 @@ public <T> Stream<T> stream(Class<T> cls) {
   }
 
   @Override
-  public <T> HttpResponse<T> withResponseHandler(HttpResponse.BodyHandler<T> responseHandler) {
+  public <T> HttpResponse<T> withHandler(HttpResponse.BodyHandler<T> responseHandler) {
     context.beforeRequest(this);
     addHeaders();
     HttpResponse<T> response = performSend(responseHandler);
@@ -420,33 +420,33 @@ protected <E> HttpResponse<E> afterAsync(HttpResponse<E> response) {
 
   @Override
   public HttpResponse<byte[]> asByteArray() {
-    return withResponseHandler(HttpResponse.BodyHandlers.ofByteArray());
+    return withHandler(HttpResponse.BodyHandlers.ofByteArray());
   }
 
   @Override
   public HttpResponse<String> asString() {
     loggableResponseBody = true;
-    return withResponseHandler(HttpResponse.BodyHandlers.ofString());
+    return withHandler(HttpResponse.BodyHandlers.ofString());
   }
 
   @Override
   public HttpResponse<Void> asDiscarding() {
-    return withResponseHandler(discarding());
+    return withHandler(discarding());
   }
 
   @Override
   public HttpResponse<InputStream> asInputStream() {
-    return withResponseHandler(HttpResponse.BodyHandlers.ofInputStream());
+    return withHandler(HttpResponse.BodyHandlers.ofInputStream());
   }
 
   @Override
   public HttpResponse<Path> asFile(Path file) {
-    return withResponseHandler(HttpResponse.BodyHandlers.ofFile(file));
+    return withHandler(HttpResponse.BodyHandlers.ofFile(file));
   }
 
   @Override
   public HttpResponse<Stream<String>> asLines() {
-    return withResponseHandler(HttpResponse.BodyHandlers.ofLines());
+    return withHandler(HttpResponse.BodyHandlers.ofLines());
   }
 
   private HttpRequest.Builder newReq(String url) {
@@ -564,7 +564,7 @@ static class HttpVoidResponse implements HttpResponse<Void> {
 
     private final HttpResponse<?> orig;
 
-    @SuppressWarnings({"unchecked", "raw"})
+    @SuppressWarnings({"raw"})
     HttpVoidResponse(HttpResponse<?> orig) {
       this.orig = orig;
     }

client/src/main/java/io/avaje/http/client/HttpClientResponse.java

@@ -108,6 +108,14 @@ public interface HttpClientResponse {
   /**
    * Return the response using the given response body handler.
    */
-  <T> HttpResponse<T> withResponseHandler(HttpResponse.BodyHandler<T> responseHandler);
+  <T> HttpResponse<T> withHandler(HttpResponse.BodyHandler<T> responseHandler);
+
+  /**
+   * Deprecated migrate to {@link #withHandler(HttpResponse.BodyHandler)}
+   */
+  @Deprecated
+  default <T> HttpResponse<T> withResponseHandler(HttpResponse.BodyHandler<T> responseHandler) {
+    return withHandler(responseHandler);
+  }
 
 }