From 6bdaca9c6bb0db2a178bed268b530c575f0afe44 Mon Sep 17 00:00:00 2001 From: Vanessa Yuen Date: Mon, 15 Apr 2019 14:44:24 -0400 Subject: [PATCH 1/3] When reporting a comment, fill in some info for the user via query string params. --- lib/views/reviews-view.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/views/reviews-view.js b/lib/views/reviews-view.js index 3f42f5bf09..adc2aa4662 100644 --- a/lib/views/reviews-view.js +++ b/lib/views/reviews-view.js @@ -537,7 +537,7 @@ export default class ReviewsView extends React.Component { pending )} - + From 0051b99cf4a7e5c8587d5c642c31c918d1835331 Mon Sep 17 00:00:00 2001 From: Vanessa Yuen Date: Tue, 16 Apr 2019 12:46:38 -0400 Subject: [PATCH 2/3] clean up and standardize the author checks throughout the file --- lib/views/reviews-view.js | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/lib/views/reviews-view.js b/lib/views/reviews-view.js index adc2aa4662..e8e0b4a19a 100644 --- a/lib/views/reviews-view.js +++ b/lib/views/reviews-view.js @@ -260,15 +260,15 @@ export default class ReviewsView extends React.Component { return null; } - const reviewAuthor = review.author ? review.author.login : ''; + const reviewAuthor = {avatarUrl: '', login: '', ...review.author}; return (
{reviewAuthor} - {reviewAuthor} + {reviewAuthor.login} {copy} {this.renderEditedLink(review)} @@ -370,6 +370,8 @@ export default class ReviewsView extends React.Component { } }; + const rootCommentAuthor = {avatarUrl: '', login: '', ...rootComment.author}; + return (
{dir ? path.sep : ''}{base} {positionText} {rootComment.author.login} @@ -519,15 +521,16 @@ export default class ReviewsView extends React.Component { } const commentClass = cx('github-Review-comment', {'github-Review-comment--pending': comment.state === 'PENDING'}); + const commentAuthor = {avatarUrl: '', login: '', ...comment.author}; return (