Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/models/user-store.js
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ export default class UserStore {
console.error(`Error fetching mentionable users:\n${response.errors.map(e => e.message).join('\n')}`);
}

if (!response.data) {
if (!response.data || !response.data.repository) {
break;
}

Expand Down
26 changes: 24 additions & 2 deletions test/models/user-store.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ describe('UserStore', function() {
const opts = {
owner: 'me',
name: 'stuff',
repositoryFound: true,
...options,
};

Expand All @@ -50,7 +51,7 @@ describe('UserStore', function() {
name: 'GetMentionableUsers',
variables: {owner: opts.owner, name: opts.name, first: 100, after: lastCursor},
}, {
repository: {
repository: !opts.repositoryFound ? null : {
mentionableUsers: {
nodes: page,
pageInfo: {
Expand Down Expand Up @@ -173,6 +174,27 @@ describe('UserStore', function() {
]);
});

it('skips GitHub remotes that no longer exist', async function() {
await login.setToken('https://api.github.com', '1234');

const workdirPath = await cloneRepository('multiple-commits');
const repository = await buildRepository(workdirPath);

await repository.setConfig('remote.origin.url', '[email protected]:me/stuff.git');
await repository.setConfig('remote.origin.fetch', '+refs/heads/*:refs/remotes/origin/*');

const [{resolve, promise}] = expectPagedRelayQueries({repositoryFound: false}, []);

store = new UserStore({repository, login, config});
await nextUpdatePromise();

resolve();
// nextUpdatePromise will not fire because the update is empty
await promise;

assert.deepEqual(store.getUsers(), []);
});

it('infers no-reply emails for users without a public email address', async function() {
await login.setToken('https://api.github.com', '1234');

Expand Down Expand Up @@ -406,8 +428,8 @@ describe('UserStore', function() {
const actualToken = await store.getToken(loginModel, 'https://api.github.com');
assert.strictEqual(expectedToken, actualToken);
});

});

describe('loadMentionableUsers', function() {
it('returns undefined if token is null', async function() {
const workdirPath = await cloneRepository('multiple-commits');
Expand Down