Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

@vanessayuenn
Copy link
Contributor

@vanessayuenn vanessayuenn commented Dec 18, 2018

I notice we have been inconsistent at remembering to change the status of feature requests from proposed to accepted when we merge the feature, and I don't think the status conveys much important information.


View rendered docs/feature-requests/000-template.md

@vanessayuenn vanessayuenn requested a review from a team December 18, 2018 13:07
@codecov
Copy link

codecov bot commented Dec 18, 2018

Codecov Report

Merging #1849 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1849      +/-   ##
==========================================
- Coverage   90.85%   90.84%   -0.01%     
==========================================
  Files         195      195              
  Lines       10727    10727              
  Branches     1570     1570              
==========================================
- Hits         9746     9745       -1     
- Misses        981      982       +1
Impacted Files Coverage Δ
lib/git-shell-out-strategy.js 87.52% <0%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 755132b...56cf3ae. Read the comment docs.

Copy link
Contributor

@smashwilson smashwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good call.

@vanessayuenn vanessayuenn merged commit a2376e9 into master Dec 18, 2018
@vanessayuenn vanessayuenn deleted the vanessayuenn-patch-1 branch December 18, 2018 14:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants