Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

"Build Status" tab does not show check runs #1818

@smashwilson

Description

@smashwilson

Prerequisites

Description

When a pull request includes Check suites in addition to commit status as part of its status, our "build status" tab does not include the check run summary.

Atom GitHub
screen shot 2018-12-03 at 10 57 15 am screen shot 2018-12-03 at 10 57 59 am

☝️ Note that Atom does not include "atom.github" from our Azure DevOps build.

Steps to Reproduce

  1. Open a pull request detail item on a pull request that includes a check suite, such as https://github.com/atom/github/pull/1807.
  2. Navigate to the "Build Status" tab.

Expected behavior:

The status shown should match the one visible on GitHub.

Actual behavior:

Only commit status is present. No check suite outcomes are reported.

Reproduces how often:

100%

Versions

$ atom --version
Atom    : 1.35.0-nightly2
Electron: 2.0.14
Chrome  : 61.0.3163.100
Node    : 8.9.3
$ apm --version
apm  2.1.3
npm  6.2.0
node 8.9.3 x64
atom 1.35.0-nightly2
python 2.7.15
git 2.19.2

macOS Mojave, Version 10.14.1 (18B75)

Additional Information

I also see that we aren't accounting for missing required checks or missing required reviews, so our summarized build status differs from the one reported on GitHub.

Annnd it would be very cool to offer deeper integration with GitHub check suites. Being able to navigate directly to the lines reported in check run annotations would be amazing. That's a whole other feature request though.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions