Merge pull request #1464 from atom/tt-18-may-load-users-bug

stop calling `repository.didUpdate` when commit message changes.

Author: Tilde Ann Thurium

lib/models/repository-states/present.js

@@ -45,11 +45,7 @@ export default class Present extends State {
   }
 
   setCommitMessage(message) {
-    const oldMessage = this.commitMessage;
     this.commitMessage = message;
-    if (oldMessage !== message) {
-      this.didUpdate();
-    }
   }
 
   getCommitMessage() {

test/controllers/commit-controller.test.js

@@ -87,6 +87,16 @@ describe('CommitController', function() {
       assert.strictEqual(wrapper.find('CommitView').prop('message'), 'some message');
     });
 
+    it('does not cause the repository to update when commit message changes', function() {
+      repository.setCommitMessage('some message');
+      const wrapper = shallow(app, {disableLifecycleMethods: true}).instance();
+      sinon.spy(wrapper.props.repository.state, 'didUpdate');
+      assert.strictEqual(wrapper.getCommitMessage(), 'some message');
+      wrapper.handleMessageChange('new message');
+      assert.strictEqual(wrapper.getCommitMessage(), 'new message');
+      assert.isFalse(wrapper.props.repository.state.didUpdate.called);
+    });
+
     describe('when a merge message is defined', function() {
       it('is set to the merge message when merging', function() {
         app = React.cloneElement(app, {isMerging: true, mergeMessage: 'merge conflict!'});