Merge pull request #1869 from atom/aw/null-repository

UserStore handles GitHub remotes that no longer exist

Author: smashwilson

lib/models/user-store.js

@@ -175,7 +175,7 @@ export default class UserStore {
         console.error(`Error fetching mentionable users:\n${response.errors.map(e => e.message).join('\n')}`);
       }
 
-      if (!response.data) {
+      if (!response.data || !response.data.repository) {
         break;
       }
 

test/models/user-store.test.js

@@ -38,6 +38,7 @@ describe('UserStore', function() {
     const opts = {
       owner: 'me',
       name: 'stuff',
+      repositoryFound: true,
       ...options,
     };
 
@@ -50,7 +51,7 @@ describe('UserStore', function() {
         name: 'GetMentionableUsers',
         variables: {owner: opts.owner, name: opts.name, first: 100, after: lastCursor},
       }, {
-        repository: {
+        repository: !opts.repositoryFound ? null : {
           mentionableUsers: {
             nodes: page,
             pageInfo: {
@@ -173,6 +174,27 @@ describe('UserStore', function() {
     ]);
   });
 
+  it('skips GitHub remotes that no longer exist', async function() {
+    await login.setToken('https://api.github.com', '1234');
+
+    const workdirPath = await cloneRepository('multiple-commits');
+    const repository = await buildRepository(workdirPath);
+
+    await repository.setConfig('remote.origin.url', '[email protected]:me/stuff.git');
+    await repository.setConfig('remote.origin.fetch', '+refs/heads/*:refs/remotes/origin/*');
+
+    const [{resolve, promise}] = expectPagedRelayQueries({repositoryFound: false}, []);
+
+    store = new UserStore({repository, login, config});
+    await nextUpdatePromise();
+
+    resolve();
+    // nextUpdatePromise will not fire because the update is empty
+    await promise;
+
+    assert.deepEqual(store.getUsers(), []);
+  });
+
   it('infers no-reply emails for users without a public email address', async function() {
     await login.setToken('https://api.github.com', '1234');
 
@@ -406,8 +428,8 @@ describe('UserStore', function() {
       const actualToken = await store.getToken(loginModel, 'https://api.github.com');
       assert.strictEqual(expectedToken, actualToken);
     });
-
   });
+
   describe('loadMentionableUsers', function() {
     it('returns undefined if token is null', async function() {
       const workdirPath = await cloneRepository('multiple-commits');