Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Commit f0869d3

Browse files
authored
Update 004-multi-file-diff.md
Move sticky nav header to "out of scope"
1 parent b9d9419 commit f0869d3

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

docs/rfcs/004-multi-file-diff.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ A new button added above the commit message box that, when clicked, opens a mult
3232
- Shows diffs of multiple files as a stack.
3333
- Each diff retains the file-specific controls it currently has in its header (e.g. the open file, stage file, undo last discard, etc).
3434
- **[[out of scope]](https://github.com/atom/github/blob/multi-diff-rfc/docs/rfcs/004-multi-file-diff.md#warning-out-of-scope)** It should be easy to jump quickly to a specific file you care about, or back to the file list to get to another file. Dotcom does so by creating a `jump to` drop down.
35-
- As user scrolls through a long list of diffs, there should be a sticky heading which remains visible showing the filename of the diff being viewed.
35+
- **[[out of scope]](https://github.com/atom/github/blob/multi-diff-rfc/docs/rfcs/004-multi-file-diff.md#warning-out-of-scope)** As user scrolls through a long list of diffs, there should be a sticky heading which remains visible showing the filename of the diff being viewed.
3636
- **[[out of scope]](https://github.com/atom/github/blob/multi-diff-rfc/docs/rfcs/004-multi-file-diff.md#warning-out-of-scope)** Each file diff can be collapsed.
3737

3838
#### Workflow
@@ -79,11 +79,11 @@ Unfiltered | Filtered
7979

8080
**Alternative**: It might be possible to re-use the find+replace UI to filter the multi-file diff. And maybe even have "replace" working.
8181

82+
#### Sticky navigation header
83+
As user scrolls through a long list of diffs, there should be a sticky heading which remains visible showing the filename of the diff being viewed.
84+
8285
#### Other out of scope UX considerations
8386
- whether `cmd+click` to select multiple files is discoverable
8487

8588
## :construction: Implementation phases
86-
TBD
87-
88-
## :white_check_mark: Definition of done
89-
TBD
89+
See [checklist on PR](https://github.com/atom/github/pull/1767)

0 commit comments

Comments
 (0)