Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Commit d02508e

Browse files
authored
Merge pull request #1805 from atom/sm/commit-preview-tweaks
Commit Preview tweaks
2 parents 4127cb3 + 3f31f60 commit d02508e

File tree

4 files changed

+9
-7
lines changed

4 files changed

+9
-7
lines changed

lib/items/commit-preview-item.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,11 +69,11 @@ export default class CommitPreviewItem extends React.Component {
6969
}
7070

7171
getTitle() {
72-
return 'Commit preview';
72+
return 'Staged Changes';
7373
}
7474

7575
getIconName() {
76-
return 'git-commit';
76+
return 'tasklist';
7777
}
7878

7979
getWorkingDirectory() {

styles/commit-view.less

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
.github-CommitView {
55
padding: @component-padding;
6-
border-top: 1px solid @base-border-color;
76
flex: 0 0 auto;
87

98
&-editor {
@@ -82,7 +81,10 @@
8281
&-buttonWrapper {
8382
align-items: center;
8483
display: flex;
85-
margin-bottom: 10px;
84+
margin: 0 -@component-padding @component-padding -@component-padding;
85+
padding: @component-padding;
86+
padding-top: 0;
87+
border-bottom: 1px solid @base-border-color;
8688
}
8789

8890
&-coAuthorEditor {

test/controllers/root-controller.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1255,7 +1255,7 @@ describe('RootController', function() {
12551255
const uri = CommitPreviewItem.buildURI(workdir);
12561256
const item = await atomEnv.workspace.open(uri);
12571257

1258-
assert.strictEqual(item.getTitle(), 'Commit preview');
1258+
assert.strictEqual(item.getTitle(), 'Staged Changes');
12591259
assert.lengthOf(wrapper.update().find('CommitPreviewItem'), 1);
12601260
});
12611261

test/items/commit-preview-item.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,8 @@ describe('CommitPreviewItem', function() {
9696
const wrapper = mount(buildPaneApp());
9797
const item = await open(wrapper);
9898

99-
assert.strictEqual(item.getTitle(), 'Commit preview');
100-
assert.strictEqual(item.getIconName(), 'git-commit');
99+
assert.strictEqual(item.getTitle(), 'Staged Changes');
100+
assert.strictEqual(item.getIconName(), 'tasklist');
101101
});
102102

103103
it('terminates pending state', async function() {

0 commit comments

Comments
 (0)