Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Commit b72a006

Browse files
authored
Replace header and footer
Plus remove outdated mockups
1 parent 6c6a5b6 commit b72a006

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

docs/feature-requests/003-pull-request-review.md

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ Peer review is also a critical part of the path to acceptance for pull requests
3232

3333
#### Header
3434

35-
![header](https://user-images.githubusercontent.com/378023/46536358-3829d180-c8e9-11e8-9167-3d1003ab566b.png)
35+
![header](https://user-images.githubusercontent.com/378023/51305325-e400c280-1a7d-11e9-9b4e-b9cf2d326dd5.png)
3636

3737
At the top of each `PullRequestDetailItem` is a summary about the pull request, followed by the tabs to switch between different sub-views.
3838

@@ -45,15 +45,9 @@ Below the tabs is a "tools bar" with controls to toggle review comments or colla
4545

4646
#### Footer
4747

48-
> TODO: Add "open" button
48+
![reviews panel](https://user-images.githubusercontent.com/378023/51305353-f2e77500-1a7d-11e9-96f0-da879d49da3a.png)
4949

50-
![reviews panel](https://user-images.githubusercontent.com/378023/46536010-17ad4780-c8e8-11e8-8338-338bb592efc5.png)
51-
52-
A panel at the bottom of the pane shows the progress for resolved review comments. It also has a "Review Changes" button to create a new review. This panel is persistent throughout all sub-views. It allows creating new reviews no matter where you are. Below examples with the existing sub-views:
53-
54-
Overview | Commits | Build Status
55-
--- | --- | ---
56-
![overview](https://user-images.githubusercontent.com/378023/46535907-ca30da80-c8e7-11e8-9401-2b8660d56c25.png) | ![commits](https://user-images.githubusercontent.com/378023/46535908-ca30da80-c8e7-11e8-87ca-01637f2554b6.png) | ![build status](https://user-images.githubusercontent.com/378023/46535909-cac97100-c8e7-11e8-8813-47fdaa3ece57.png)
50+
A panel at the bottom of the pane shows the progress for resolved review comments. It also has a "Review Changes" button to create a new review. This panel is persistent throughout all sub-views. It allows creating new reviews no matter where you are.
5751

5852
When the pull request is checked out, an "open" button is shown in the review footer. Clicking "open" opens a `PullRequestReviewsItem` for this pull request's review comments as an item in the right workspace dock.
5953

0 commit comments

Comments
 (0)