address code review feedback.

Tilde Ann Thurium · Tilde Ann Thurium · commit 4e400bde1198 · 2018-11-06T14:52:43.000-08:00
diff --git a/lib/models/repository-states/present.js b/lib/models/repository-states/present.js
@@ -196,14 +196,13 @@ export default class Present extends State {
 
       if (filePathEndsWith(event.path, '.git', 'config')) {
         // this won't catch changes made to the template file itself...
-        let template = await this.fetchCommitMessageTemplate();
+        const template = await this.fetchCommitMessageTemplate();
         if (template === null) {
-          template = '';
-        }
-        if (this.commitMessageTemplate !== template) {
-          this.setCommitMessageTemplate(template);
+          this.setCommitMessage('');
+        } else if (this.commitMessageTemplate !== template) {
           this.setCommitMessage(template);
         }
+        this.setCommitMessageTemplate(template);
       }
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -196,14 +196,13 @@ export default class Present extends State {`
`196`	`196`
`197`	`197`	`if (filePathEndsWith(event.path, '.git', 'config')) {`
`198`	`198`	`// this won't catch changes made to the template file itself...`
`199`		`- let template = await this.fetchCommitMessageTemplate();`
	`199`	`+ const template = await this.fetchCommitMessageTemplate();`
`200`	`200`	`if (template === null) {`
`201`		`- template = '';`
`202`		`- }`
`203`		`- if (this.commitMessageTemplate !== template) {`
`204`		`- this.setCommitMessageTemplate(template);`
	`201`	`+ this.setCommitMessage('');`
	`202`	`+ } else if (this.commitMessageTemplate !== template) {`
`205`	`203`	`this.setCommitMessage(template);`
`206`	`204`	`}`
	`205`	`+ this.setCommitMessageTemplate(template);`
`207`	`206`	`}`
`208`	`207`	`}`
`209`	`208`	`}`