add isDiffRowOffsetIndexEmpty for better readability

Author: annthurium

lib/models/patch/multi-file-patch.js

@@ -196,6 +196,10 @@ export default class MultiFilePatch {
     return Range.fromObject([[selectionRow, 0], [selectionRow, Infinity]]);
   }
 
+  isDiffRowOffsetIndexEmpty(filePatchPath) {
+    const diffRowOffsetIndex = this.diffRowOffsetIndices.get(filePatchPath);
+    return diffRowOffsetIndex.index.size === 0;
+  }
   populateDiffRowOffsetIndices(filePatch) {
     let diffRow = 1;
     const index = new RBTree((a, b) => a.diffRow - b.diffRow);
@@ -337,10 +341,9 @@ export default class MultiFilePatch {
       this.hunksByMarker.set(hunk.getMarker(), hunk);
     }
 
-    const diffRowOffsetIndex = this.diffRowOffsetIndices.get(filePatch.getPath());
     // if the patch was initially collapsed, we need to calculate
     // the diffRowOffsetIndices to calculate comment position.
-    if (diffRowOffsetIndex.index.size === 0) {
+    if (this.isDiffRowOffsetIndexEmpty(filePatch.getPath())) {
       this.populateDiffRowOffsetIndices(filePatch);
     }
   }

test/models/patch/multi-file-patch.test.js

@@ -791,10 +791,10 @@ describe('MultiFilePatch', function() {
           fp.renderStatus(TOO_LARGE);
         })
         .build();
-      assert.strictEqual(multiFilePatch.diffRowOffsetIndices.get('1.txt').index.size, 0);
+      assert.isTrue(multiFilePatch.isDiffRowOffsetIndexEmpty('1.txt'));
       const [fp] = multiFilePatch.getFilePatches();
       multiFilePatch.expandFilePatch(fp);
-      assert.strictEqual(multiFilePatch.diffRowOffsetIndices.get('1.txt').index.size, 3);
+      assert.isFalse(multiFilePatch.isDiffRowOffsetIndexEmpty('1.txt'));
       assert.strictEqual(multiFilePatch.getBufferRowForDiffPosition('1.txt', 11), 9);
     });