Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Commit 3d99d94

Browse files
author
Tilde Ann Thurium
authored
Merge pull request #1711 from MimiDumpling/mimi-fix-commit
Fixed merged commit text
2 parents 46afadd + 86ad935 commit 3d99d94

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

lib/views/timeline-items/merged-event-view.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export class BareMergedEventView extends React.Component {
2727
<Octicon className="pre-timeline-item-icon" icon="git-merge" />
2828
{actor && <img className="author-avatar" src={actor.avatarUrl} alt={actor.login} title={actor.login} />}
2929
<span className="merged-event-header">
30-
<span className="username">{actor ? actor.login : 'someone'}</span> merged
30+
<span className="username">{actor ? actor.login : 'someone'}</span> merged{' '}
3131
{this.renderCommit()} into
3232
{' '}<span className="merge-ref">{mergeRefName}</span> on <Timeago time={createdAt} />
3333
</span>

test/views/timeline-items/merged-event-view.test.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,4 +60,11 @@ describe('MergedEventView', function() {
6060
assert.strictEqual(wrapper.find('.username').text(), 'someone');
6161
assert.isFalse(wrapper.find('.sha').exists());
6262
});
63+
64+
it('renders a space between merged and commit', function() {
65+
const wrapper = shallow(buildApp({}));
66+
const text = wrapper.find('.merged-event-header').text();
67+
68+
assert.isTrue(text.includes('merged commit'));
69+
});
6370
});

0 commit comments

Comments
 (0)