Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Commit 3bc411e

Browse files
committed
We actually called it "Files Changed," not "Files"
1 parent 3ff9662 commit 3bc411e

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

docs/feature-requests/003-pull-request-review.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@ Overview | Commits | Build Status
5757

5858
When the pull request is checked out, an "open" button is shown in the review footer. Clicking "open" opens a `PullRequestReviewsItem` for this pull request's review comments as an item in the right workspace dock.
5959

60-
### Files (tab)
60+
### Files Changed (tab)
6161

62-
Clicking on the "Files" tab displays the full, multi-file diff associated with the pull request. This is akin to the "Files changed" tab on dotcom.
62+
Clicking on the "Files Changed" tab displays the full, multi-file diff associated with the pull request. This is akin to the "Files changed" tab on dotcom.
6363

6464
![files](https://user-images.githubusercontent.com/378023/46536560-d3bb4200-c8e9-11e8-9764-dca0b84245cf.png)
6565

@@ -119,7 +119,7 @@ This item is opened in the workspace's right dock when the user:
119119

120120
* Clicks the review progress bar in the GitHub tab.
121121
* Clicks the "open" button on the review summary footer of a `PullRequestDetailItem`.
122-
* Clicks the "<>" button on a review comment in the "Files" tab of a `PullRequestDetailItem`.
122+
* Clicks the "<>" button on a review comment in the "Files Changed" tab of a `PullRequestDetailItem`.
123123

124124
It shows a scrollable view of all of the reviews and comments associated with a specific pull request,
125125

@@ -160,7 +160,7 @@ In order to navigate between comments or switch context, each comment has the fo
160160
* Clicking on the `<>` button in a review comment shows the comment in the entire file. If possible, the scroll-position is retained. This allows to quickly get more context about the code.
161161
* If the current pull request is not checked out, the `<>` button is disabled, and a tooltip prompts the user to check out the pull request to edit the source.
162162
* Clicking on the "sandwich" button shows the comment in the corresponding `PullRequestReviewsItem`.
163-
* Clicking on the "file-+" button (not shown in above screenshot) shows the comment under the "Files" tab.
163+
* Clicking on the "file-+" button (not shown in above screenshot) shows the comment under the "Files Changed" tab.
164164
* The up and down arrow buttons navigate to the next and previous unresolved review comments.
165165
* Reaction emoji may be added to each comment with the "emoji" button. Existing emoji reaction tallies are included beneath each comment.
166166

0 commit comments

Comments
 (0)