Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Commit 2ab74b5

Browse files
smashwilsonSarah Guthals
andcommitted
Create a pending review if one is not present
Co-Authored-By: Sarah Guthals <[email protected]>
1 parent 6313744 commit 2ab74b5

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

docs/rfcs/XXX-pull-request-review.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,16 @@ Reviews on the current pull request are rendered as a list on the current pull r
3030
* Line comments within the review are rendered: _with a vertical blue bar_ before the file has been opened and the corresponding decoration is visible; _with a vertical grey bar_ after the file and decoration have been seen; and _with a vertical green bar_ after the comment has been marked "resolved" with the control on its decoration.
3131
* The review summary bubble and line comment lists are greyed out if a different `IssueishDetailItem` is activated.
3232

33-
If a new review has been started locally, it appears at the top of the "Reviews" section within this tile:
33+
If a pending review is present, it appears at the top of the "Reviews" section within this tile:
3434

3535
![pending-review](https://user-images.githubusercontent.com/378023/46275946-9bd69680-c599-11e8-9889-66c35458286a.png)
3636

3737
* The review summary is a TextEditor that may be used to compose a summary comment.
3838
* Choosing "Cancel" dismisses the review and any comments made. If there are local review comments that will be lost, a confirmation prompt is shown first.
3939
* Choosing "Submit review" submits the drafted review to GitHub.
4040

41+
If there is no pending review, the tile instead displays a control to create one.
42+
4143
### IssueishDetailItem
4244

4345
Each `IssueishDetailItem` opened on a pull request displays the full, multi-file diff associated with the pull request.

0 commit comments

Comments
 (0)