You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Copy file name to clipboardExpand all lines: docs/rfcs/XXX-pull-request-review.md
+3-1Lines changed: 3 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -30,14 +30,16 @@ Reviews on the current pull request are rendered as a list on the current pull r
30
30
* Line comments within the review are rendered: _with a vertical blue bar_ before the file has been opened and the corresponding decoration is visible; _with a vertical grey bar_ after the file and decoration have been seen; and _with a vertical green bar_ after the comment has been marked "resolved" with the control on its decoration.
31
31
* The review summary bubble and line comment lists are greyed out if a different `IssueishDetailItem` is activated.
32
32
33
-
If a new review has been started locally, it appears at the top of the "Reviews" section within this tile:
33
+
If a pending review is present, it appears at the top of the "Reviews" section within this tile:
* The review summary is a TextEditor that may be used to compose a summary comment.
38
38
* Choosing "Cancel" dismisses the review and any comments made. If there are local review comments that will be lost, a confirmation prompt is shown first.
39
39
* Choosing "Submit review" submits the drafted review to GitHub.
40
40
41
+
If there is no pending review, the tile instead displays a control to create one.
42
+
41
43
### IssueishDetailItem
42
44
43
45
Each `IssueishDetailItem` opened on a pull request displays the full, multi-file diff associated with the pull request.
0 commit comments