add/modify some tests

Author: vanessayuenn

lib/controllers/reviews-controller.js

@@ -14,7 +14,7 @@ import unresolveReviewThreadMutation from '../mutations/unresolve-review-thread'
 import IssueishDetailItem from '../items/issueish-detail-item';
 import {addEvent} from '../reporter-proxy';
 
-// Milliseconds to leave scrollToThreadID non-null before reverting.
+// Milliseconds to update highlightedThreadIDs
 const FLASH_DELAY = 1500;
 
 export class BareReviewsController extends React.Component {

lib/views/reviews-view.js

@@ -649,6 +649,7 @@ export default class ReviewsView extends React.Component {
     return {lineNumber, positionText};
   }
 
+  /* istanbul ignore next */
   scrollToThread(threadID) {
     const threadHolder = this.threadHolders.get(threadID);
     if (threadHolder) {

test/controllers/reviews-controller.test.js

@@ -95,20 +95,22 @@ describe('ReviewsController', function() {
     assert.strictEqual(opWrapper.find(ReviewsView).prop('extra'), extra);
   });
 
-  it('scrolls to a specific thread on mount', function() {
+  it('scrolls to and highlight a specific thread on mount', function() {
     clock = sinon.useFakeTimers();
     const wrapper = shallow(buildApp({initThreadID: 'thread0'}));
     let opWrapper = wrapper.find(PullRequestCheckoutController).renderProp('children')(noop);
 
     assert.include(opWrapper.find(ReviewsView).prop('threadIDsOpen'), 'thread0');
+    assert.include(opWrapper.find(ReviewsView).prop('highlightedThreadIDs'), 'thread0');
     assert.strictEqual(opWrapper.find(ReviewsView).prop('scrollToThreadID'), 'thread0');
 
     clock.tick(2000);
     opWrapper = wrapper.find(PullRequestCheckoutController).renderProp('children')(noop);
+    assert.notInclude(opWrapper.find(ReviewsView).prop('highlightedThreadIDs'), 'thread0');
     assert.isNull(opWrapper.find(ReviewsView).prop('scrollToThreadID'));
   });
 
-  it('scrolls to a specific thread on update', function() {
+  it('scrolls to and highlight a specific thread on update', function() {
     clock = sinon.useFakeTimers();
     const wrapper = shallow(buildApp());
     let opWrapper = wrapper.find(PullRequestCheckoutController).renderProp('children')(noop);
@@ -118,11 +120,13 @@ describe('ReviewsController', function() {
     opWrapper = wrapper.find(PullRequestCheckoutController).renderProp('children')(noop);
 
     assert.include(opWrapper.find(ReviewsView).prop('threadIDsOpen'), 'hang-by-a-thread');
+    assert.include(opWrapper.find(ReviewsView).prop('highlightedThreadIDs'), 'hang-by-a-thread');
     assert.isTrue(opWrapper.find(ReviewsView).prop('commentSectionOpen'));
     assert.strictEqual(opWrapper.find(ReviewsView).prop('scrollToThreadID'), 'hang-by-a-thread');
 
     clock.tick(2000);
     opWrapper = wrapper.find(PullRequestCheckoutController).renderProp('children')(noop);
+    assert.notInclude(opWrapper.find(ReviewsView).prop('highlightedThreadIDs'), 'hang-by-a-thread');
     assert.isNull(opWrapper.find(ReviewsView).prop('scrollToThreadID'));
   });
 

test/views/reviews-view.test.js

@@ -292,6 +292,13 @@ describe('ReviewsView', function() {
       assert.strictEqual(comment.find('em').text(), 'This comment was hidden');
     });
 
+    it('groups comments by their resolved status', function() {
+      const unresolvedThreads = wrapper.find('.github-Reviews-section.comments').find('.github-Review');
+      const resolvedThreads = wrapper.find('.github-Reviews-section.resolved-comments').find('.github-Review');
+      assert.lengthOf(resolvedThreads, 1);
+      assert.lengthOf(unresolvedThreads, 3);
+    });
+
     describe('indication that a comment has been edited', function() {
       it('indicates that a review summary comment has been edited', function() {
         const summary = wrapper.find('.github-ReviewSummary').at(0);