debug: update hacl hmac extension module setup

Author: zanieb

cpython-unix/build.py

@@ -249,7 +249,7 @@ def simple_build(
 ):
     archive = download_entry(entry, DOWNLOADS_PATH)
 
-    with build_environment(client, image, entry) as build_env:
+    with build_environment(client, image) as build_env:
         if settings.get("needs_toolchain"):
             build_env.install_toolchain(
                 BUILD,
@@ -291,7 +291,7 @@ def build_binutils(client, image, host_platform):
     """Build binutils in the Docker image."""
     archive = download_entry("binutils", DOWNLOADS_PATH)
 
-    with build_environment(client, image, "binutils") as build_env:
+    with build_environment(client, image) as build_env:
         install_sccache(build_env)
 
         build_env.copy_file(archive)
@@ -332,7 +332,7 @@ def build_musl(client, image, host_platform: str, target_triple: str, build_opti
     musl = "musl-static" if static else "musl"
     musl_archive = download_entry(musl, DOWNLOADS_PATH)
 
-    with build_environment(client, image, "musl") as build_env:
+    with build_environment(client, image) as build_env:
         build_env.install_toolchain(
             BUILD,
             host_platform,
@@ -362,7 +362,7 @@ def build_libedit(
 ):
     libedit_archive = download_entry("libedit", DOWNLOADS_PATH)
 
-    with build_environment(client, image, "libedit") as build_env:
+    with build_environment(client, image) as build_env:
         if settings.get("needs_toolchain"):
             build_env.install_toolchain(
                 BUILD,
@@ -397,7 +397,7 @@ def build_tix(
     tk_archive = download_entry("tk", DOWNLOADS_PATH)
     tix_archive = download_entry("tix", DOWNLOADS_PATH)
 
-    with build_environment(client, image, "tix") as build_env:
+    with build_environment(client, image) as build_env:
         if settings.get("needs_toolchain"):
             build_env.install_toolchain(
                 BUILD,
@@ -444,7 +444,7 @@ def build_cpython_host(
     """Build binutils in the Docker image."""
     archive = download_entry(entry, DOWNLOADS_PATH)
 
-    with build_environment(client, image, "cpython-host") as build_env:
+    with build_environment(client, image) as build_env:
         python_version = DOWNLOADS[entry]["version"]
 
         build_env.install_toolchain(
@@ -773,7 +773,7 @@ def build_cpython(
     setup_local_content = setup["setup_local"]
     extra_make_content = setup["make_data"]
 
-    with build_environment(client, image, "cpython") as build_env:
+    with build_environment(client, image) as build_env:
         if settings.get("needs_toolchain"):
             build_env.install_toolchain(
                 BUILD,

cpython-unix/extension-modules.yml

@@ -315,10 +315,18 @@ _hmac:
   minimum-python-version: '3.14'
   sources:
     - hmacmodule.c
+    - _hacl/Hacl_HMAC.c
+    - _hacl/Hacl_Streaming_HMAC.c
   includes:
-    - Modules/_hacl
+    - Modules/_hacl/
+    - Modules/_hacl/include/
+    - Modules/_hacl/include/krml/
   links:
     - :libHacl_Hash_Blake2.a
+    - :libHacl_Hash_SHA1.a
+    - :libHacl_Hash_SHA2.a
+    - :libHacl_Hash_SHA3.a
+    - :libHacl_Hash_MD5.a
 
 _imp:
   config-c-only: true
@@ -371,6 +379,10 @@ _md5:
   sources-conditional:
     - source: _hacl/Hacl_Hash_MD5.c
       minimum-python-version: "3.12"
+      maximum-python-version: "3.13"
+  links-conditional:
+    - name: :libHacl_Hash_MD5.a
+      minimum-python-version: "3.14"
   defines-conditional:
     - define: _BSD_SOURCE
       minimum-python-version: "3.12"
@@ -447,6 +459,10 @@ _sha1:
   sources-conditional:
     - source: _hacl/Hacl_Hash_SHA1.c
       minimum-python-version: "3.12"
+      maximum-python-version: "3.13"
+  links-conditional:
+    - name: :libHacl_Hash_SHA1.a
+      minimum-python-version: "3.14"
   includes:
     - Modules/_hacl/include
   defines-conditional:
@@ -466,7 +482,12 @@ _sha2:
   minimum-python-version: "3.12"
   sources:
     - sha2module.c
-    - _hacl/Hacl_Hash_SHA2.c
+  sources-conditional:
+    - source: _hacl/Hacl_Hash_SHA2.c
+      maximum-python-version: "3.13"
+  links-conditional:
+    - name: :libHacl_Hash_SHA2.a
+      minimum-python-version: "3.14"
   includes:
     - Modules/_hacl/include
   defines:
@@ -480,9 +501,12 @@ _sha3:
       maximum-python-version: "3.11"
     - source: sha3module.c
       minimum-python-version: "3.12"
-
     - source: _hacl/Hacl_Hash_SHA3.c
       minimum-python-version: "3.12"
+      maximum-python-version: "3.13"
+  links-conditional:
+    - name: :libHacl_Hash_SHA3.a
+      minimum-python-version: "3.14"
   includes:
     - Modules/_hacl/include
   defines-conditional:

pythonbuild/buildenv.py

@@ -7,9 +7,7 @@
 import io
 import os
 import pathlib
-import random
 import shutil
-import string
 import tarfile
 import tempfile
 
@@ -266,25 +264,22 @@ def find_output_files(self, base_path, pattern):
 
 
 @contextlib.contextmanager
-def build_environment(client, image, name):
+def build_environment(client, image):
     if client is not None:
-        suffix = "".join(random.choices(string.ascii_uppercase + string.digits, k=8))
         container = client.containers.run(
-            image, command=["/bin/sleep", "86400"], name=f"{name}-{suffix}", detach=True
+            image, command=["/bin/sleep", "86400"], detach=True
         )
         td = None
         context = ContainerContext(container)
     else:
         container = None
-        td = tempfile.TemporaryDirectory(prefix=f"{name}-", delete=False)
+        td = tempfile.TemporaryDirectory()
         context = TempdirContext(td.name)
 
     try:
         yield context
     finally:
-        if os.environ.get("PYBUILD_KEEP_ENV"):
-            pass
-        elif container:
+        if container:
             container.stop(timeout=0)
             container.remove()
         else: