Not sure why SonarQube isn't getting the test coverage... (#5)

* Not sure why SonarQube isn't getting the test coverage...

I am sure the separation worked, but let's see if this works...

* Update main_astar-dev.yml

Copied from SonarQube but do not believe it will make a difference as, bar emojis etc., the previous one was too (allbeit originally from another project)

* Found a better / different approach - in desc

https://docs.sonarsource.com/sonarqube-cloud/enriching/test-coverage/dotnet-test-coverage/#examples-using-the-net-tool-scanner-variant

* Put back the permissions limit

lost in the earlier copy from SonarQube example (really SQ? you don't have in the template...)

* Oh, c'mon!

* Need to see how to contribute to SQ docs...

add .\.sonar\scanner\dotnet-sonarscanner as that is where the SQ docs actually install it...

* Update the filter to exclude Integration Tests too

* Silly boy... FullyQualifiedName can't work if the project doesn't use...

* it helps if a) actually fully qualified n b) remember to escape !

* OK, let's try including Tests.Unit rather than excluding others

* ignore the 2 tests failing on GitHub but passing locally...

* Hopefully, this is the last issue

* Yet another difference between SQ examples and apparent requirements

---------

Co-authored-by: Jason Barden <[email protected]>

Author: jaybarden1

.github/workflows/main_astar-dev.yml

@@ -1,110 +1,51 @@
-name: Build and analyse the DatabaseTesting Solution
+name: SonarQube
+permissions:
+  contents: read
 on:
-  pull_request:
-    types: [ opened, synchronize, reopened ]
   push:
     branches:
       - main
-env:
-  AZURE_WEBAPP_NAME: astar-dev
-  AZURE_WEBAPP_PACKAGE_PATH: src/uis/AStar.Dev.Web/published
-  CONFIGURATION: Release
-  DOTNET_CORE_VERSION: 9.0.x
-  WORKING_DIRECTORY: src/uis/AStar.Dev.Web
+  pull_request:
+    types: [ opened, synchronize, reopened ]
 jobs:
   build:
+    name: Build and analyze
     runs-on: windows-latest
-    permissions:
-      contents: read #This is required for actions/checkout
-
     steps:
       - name: Set up JDK 17
         uses: actions/setup-java@v4
         with:
           java-version: 17
-          distribution: 'zulu'
-
+          distribution: 'zulu' # Alternative distribution options are available.
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0  # Shallow clones should be disabled for a better relevancy of analysis
-
-      - name: 🛠 Cache SonarQube Cloud packages
+      - name: Cache SonarQube Cloud packages
         uses: actions/cache@v4
         with:
           path: ~\sonar\cache
           key: ${{ runner.os }}-sonar
           restore-keys: ${{ runner.os }}-sonar
-
-      - name: 🛠 Cache SonarQube Cloud scanner
+      - name: Cache SonarQube Cloud scanner
         id: cache-sonar-scanner
         uses: actions/cache@v4
         with:
           path: .\.sonar\scanner
           key: ${{ runner.os }}-sonar-scanner
           restore-keys: ${{ runner.os }}-sonar-scanner
-
-      - name: 🛠 Install SonarQube Cloud scanner
+      - name: Install SonarQube Cloud scanner
         if: steps.cache-sonar-scanner.outputs.cache-hit != 'true'
         shell: powershell
         run: |
-          New-Item -Path .\.sonar\scanner -ItemType Directory 
+          New-Item -Path .\.sonar\scanner -ItemType Directory
           dotnet tool update dotnet-sonarscanner --tool-path .\.sonar\scanner
-
-      - name: 🔍 Restore,
-        shell: powershell
-        run: |
-          dotnet restore
-
-      - name: 🛠 Build
-        shell: powershell
-        run: |
-          dotnet build --no-restore
-
-      - name: 🧪 Test and analyse with ☁️ SonarCloud / Qube
+      - name: Build and analyze
         env:
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
         shell: powershell
         run: |
           dotnet tool install --global dotnet-coverage
-          .\.sonar\scanner\dotnet-sonarscanner begin /k:"astar-development_astar-dev-database-testing" /o:"astar-development" /d:sonar.token="${{ secrets.SONAR_TOKEN }}" /d:sonar.host.url="https://sonarcloud.io" /d:sonar.scanner.scanAll=false /d:sonar.scanner.skipJreProvisioning=true
-          dotnet-coverage collect 'dotnet test --filter "FullyQualifiedName!~Tests.EndToEnd"' -f xml -o 'coverage.xml'
+          .\.sonar\scanner\dotnet-sonarscanner begin /k:"astar-development_astar-dev-database-testing" /o:"astar-development" /d:sonar.token="${{ secrets.SONAR_TOKEN }}" /d:sonar.cs.vscoveragexml.reportsPaths=coverage.xml /d:sonar.host.url="https://sonarcloud.io" /d:sonar.scanner.scanAll=false /d:sonar.scanner.skipJreProvisioning=true
+          dotnet build --no-incremental
+          dotnet-coverage collect 'dotnet test --filter "FullyQualifiedName~Tests.Unit"' -f xml -o 'coverage.xml'
           .\.sonar\scanner\dotnet-sonarscanner end /d:sonar.token="${{ secrets.SONAR_TOKEN }}"
-#
-#      - name: 🚀 Publish App
-#        run: dotnet publish "${{ env.WORKING_DIRECTORY }}" --configuration ${{ env.CONFIGURATION }} --no-build --output "${{ env.AZURE_WEBAPP_PACKAGE_PATH }}"
-#
-#      - name: 🚀 Publish Artifacts
-#        uses: actions/upload-artifact@v4
-#        with:
-#          name: webapp
-#          path: ${{ env.AZURE_WEBAPP_PACKAGE_PATH }}
-
-#  deploy:
-#    runs-on: ubuntu-latest
-#    needs: build
-#    environment:
-#      name: 'Production'
-#      url: ${{ steps.deploy-to-webapp.outputs.webapp-url }}
-#    permissions:
-#      id-token: write #This is required for requesting the JWT
-#      contents: read #This is required for actions/checkout
-#
-#    steps:
-#    - name: Download artifact from build job
-#      uses: actions/download-artifact@v4
-#      with:
-#        name: webapp
-#        path: ${{ env.AZURE_WEBAPP_PACKAGE_PATH }}
-#
-#    - name: Login to Azure
-#      uses: azure/login@v2
-#      with:
-#        client-id: ${{ secrets.AZUREAPPSERVICE_CLIENTID_E8497C9E217E4655814D0F7761AAE04F }}
-#        tenant-id: ${{ secrets.AZUREAPPSERVICE_TENANTID_085200BD39F041C4999EEB0851E8D6A2 }}
-#        subscription-id: ${{ secrets.AZUREAPPSERVICE_SUBSCRIPTIONID_3FEB324333C140D8A0FA99AC083AEB82 }}
-#
-#    - name: Deploy to Azure WebApp
-#      uses: azure/webapps-deploy@v3
-#      with:
-#        app-name: ${{ env.AZURE_WEBAPP_NAME }}
-#        package: ${{ env.AZURE_WEBAPP_PACKAGE_PATH }}

test/AStar.Dev.Infrastructure.FilesDb.Tests.Integration/AStar.Dev.Infrastructure.FilesDb.Tests.Integration.csproj

@@ -5,7 +5,7 @@
         <ImplicitUsings>enable</ImplicitUsings>
         <Nullable>enable</Nullable>
         <IsPackable>false</IsPackable>
-        <RootNamespace>AStar.Dev.Infrastructure.FilesDb</RootNamespace>
+        <RootNamespace>AStar.Dev.Infrastructure.FilesDb.Tests.Integration</RootNamespace>
         <UserSecretsId>8f6cdef5-4769-401b-a5d6-bf409c7b76d6</UserSecretsId>
     </PropertyGroup>
 

test/AStar.Dev.Infrastructure.FilesDb.Tests.Integration/FileDetailDeletionStatusExtensionsShould.cs

@@ -2,7 +2,7 @@
 using DbContextHelpers.Fixtures;
 using Shouldly;
 
-namespace AStar.Dev.Infrastructure.FilesDb;
+namespace AStar.Dev.Infrastructure.FilesDb.Tests.Integration;
 
 /// <summary>
 /// </summary>

test/AStar.Dev.Infrastructure.FilesDb.Tests.Integration/FileDetailDirectoryNameExtensionsShould.cs

@@ -3,7 +3,7 @@
 using DbContextHelpers.Fixtures;
 using Shouldly;
 
-namespace AStar.Dev.Infrastructure.FilesDb;
+namespace AStar.Dev.Infrastructure.FilesDb.Tests.Integration;
 
 public class FileDetailDirectoryNameExtensionsShould (FilesContextFixture filesContextFixture) : IClassFixture<FilesContextFixture>
 {

test/AStar.Dev.Infrastructure.FilesDb.Tests.Integration/FileDetailOrderingExtensionsShould.cs

@@ -3,7 +3,7 @@
 using DbContextHelpers.Fixtures;
 using Shouldly;
 
-namespace AStar.Dev.Infrastructure.FilesDb;
+namespace AStar.Dev.Infrastructure.FilesDb.Tests.Integration;
 
 /// <summary>
 /// </summary>

test/AStar.Dev.Infrastructure.FilesDb.Tests.Integration/FileDetailPagingExtensionsShould.cs

@@ -2,7 +2,7 @@
 using DbContextHelpers.Fixtures;
 using Shouldly;
 
-namespace AStar.Dev.Infrastructure.FilesDb;
+namespace AStar.Dev.Infrastructure.FilesDb.Tests.Integration;
 
 /// <summary>
 /// </summary>

test/AStar.Dev.Infrastructure.FilesDb.Tests.Integration/FileDetailSearchTypeExtensionsShould.cs

@@ -3,7 +3,7 @@
 using DbContextHelpers.Fixtures;
 using Shouldly;
 
-namespace AStar.Dev.Infrastructure.FilesDb;
+namespace AStar.Dev.Infrastructure.FilesDb.Tests.Integration;
 
 /// <summary>
 /// </summary>

test/AStar.Dev.Infrastructure.FilesDb.Tests.Integration/FileDetailTextContainsExtensionsShould.cs

@@ -2,7 +2,7 @@
 using DbContextHelpers.Fixtures;
 using Shouldly;
 
-namespace AStar.Dev.Infrastructure.FilesDb;
+namespace AStar.Dev.Infrastructure.FilesDb.Tests.Integration;
 
 /// <summary>
 /// </summary>

test/AStar.Dev.Infrastructure.FilesDb.Tests.Integration/FilesContextLastViewedExtensionsShould.cs

@@ -3,7 +3,7 @@
 using Microsoft.Extensions.Time.Testing;
 using Shouldly;
 
-namespace AStar.Dev.Infrastructure.FilesDb;
+namespace AStar.Dev.Infrastructure.FilesDb.Tests.Integration;
 
 public class FilesContextLastViewedExtensionsShould : IClassFixture<FilesContextFixture>
 {

test/AStar.Dev.Infrastructure.FilesDb.Tests.Unit/AStar.Dev.Infrastructure.FilesDb.Tests.Unit.csproj

@@ -5,7 +5,6 @@
         <ImplicitUsings>enable</ImplicitUsings>
         <Nullable>enable</Nullable>
         <IsPackable>false</IsPackable>
-        <RootNamespace>AStar.Dev.Infrastructure.FilesDb</RootNamespace>
     </PropertyGroup>
 
     <ItemGroup>