Add missing test for the ComplexPropertyBuilderConfiguration.cs

which triggered a few other code changes but, test-wise, it compiles and passes

Author: jbarden

src/AStar.Dev.Infrastructure.FilesDb/Data/Configurations/DeletionStatusConfiguration.cs

@@ -7,13 +7,13 @@ namespace AStar.Dev.Infrastructure.FilesDb.Data.Configurations;
 
 internal sealed class DeletionStatusConfiguration : IComplexPropertyConfiguration<DeletionStatus>
 {
-    public ComplexPropertyBuilder<DeletionStatus> Configure(ComplexPropertyBuilder<DeletionStatus> builder)
+    public void Configure(ComplexPropertyBuilder<DeletionStatus> builder)
     {
         builder
             .Property(deletionStatus => deletionStatus.HardDeletePending)
             .HasColumnName("HardDeletePending")
             .HasColumnType("datetimeoffset");
-        
+
         builder
             .Property(deletionStatus => deletionStatus.SoftDeletePending)
             .HasColumnName("SoftDeletePending")
@@ -23,7 +23,5 @@ public ComplexPropertyBuilder<DeletionStatus> Configure(ComplexPropertyBuilder<D
             .Property(deletionStatus => deletionStatus.SoftDeleted)
             .HasColumnName("SoftDeleted")
             .HasColumnType("datetimeoffset");
-
-        return builder;
     }
 }

src/AStar.Dev.Infrastructure.FilesDb/Data/Configurations/DirectoryNameConfiguration.cs

@@ -7,12 +7,10 @@ namespace AStar.Dev.Infrastructure.FilesDb.Data.Configurations;
 
 internal sealed class DirectoryNameConfiguration : IComplexPropertyConfiguration<DirectoryName>
 {
-    public ComplexPropertyBuilder<DirectoryName> Configure(ComplexPropertyBuilder<DirectoryName> builder)
+    public void Configure(ComplexPropertyBuilder<DirectoryName> builder)
     {
         builder.Property(directoryName => directoryName.Value)
             .HasColumnName("DirectoryName")
             .HasColumnType("nvarchar(256)");
-
-        return builder;
     }
 }

src/AStar.Dev.Infrastructure.FilesDb/Data/Configurations/EventTypeConfiguration.cs

@@ -7,11 +7,9 @@ namespace AStar.Dev.Infrastructure.FilesDb.Data.Configurations;
 
 internal sealed class EventTypeConfiguration : IComplexPropertyConfiguration<EventType>
 {
-    public ComplexPropertyBuilder<EventType> Configure(ComplexPropertyBuilder<EventType> builder)
+    public void Configure(ComplexPropertyBuilder<EventType> builder)
     {
         builder.Property(eventType => eventType.Value).HasColumnName("EventType").IsRequired();
         builder.Property(eventType => eventType.Name).HasColumnName("EventName").IsRequired();
-
-        return builder;
     }
 }

src/AStar.Dev.Infrastructure.FilesDb/Data/Configurations/ImageDetailConfiguration.cs

@@ -7,11 +7,9 @@ namespace AStar.Dev.Infrastructure.FilesDb.Data.Configurations;
 
 internal sealed class ImageDetailConfiguration : IComplexPropertyConfiguration<ImageDetail>
 {
-    public ComplexPropertyBuilder<ImageDetail> Configure(ComplexPropertyBuilder<ImageDetail> builder)
+    public void Configure(ComplexPropertyBuilder<ImageDetail> builder)
     {
         builder.Property(image => image.Width).HasColumnName("ImageWidth");
         builder.Property(image => image.Height).HasColumnName("ImageHeight");
-
-        return builder;
     }
 }

src/AStar.Dev.Infrastructure/AStar.Dev.Infrastructure.xml

@@ -12,7 +12,7 @@ public static class ComplexPropertyBuilderConfiguration
     /// <param name="configuration"></param>
     /// <typeparam name="TEntity"></typeparam>
     /// <returns></returns>
-    public static ComplexPropertyBuilder<TEntity> Configure<TEntity>(this ComplexPropertyBuilder<TEntity>   propertyBuilder, IComplexPropertyConfiguration<TEntity> configuration)
+    public static ComplexPropertyBuilder<TEntity> Configure<TEntity>(this ComplexPropertyBuilder<TEntity> propertyBuilder, IComplexPropertyConfiguration<TEntity> configuration)
     {
         configuration.Configure(propertyBuilder);
 

src/AStar.Dev.Infrastructure/Data/Configurations/ComplexPropertyBuilderConfiguration.cs

@@ -5,11 +5,11 @@ namespace AStar.Dev.Infrastructure.Data.Configurations;
 /// <summary>
 /// </summary>
 /// <typeparam name="TEntity"></typeparam>
-public interface IComplexPropertyConfiguration<TEntity> 
+public interface IComplexPropertyConfiguration<TEntity>
 {
     /// <summary>
     /// </summary>
     /// <param name="builder"></param>
     /// <returns></returns>
-    public ComplexPropertyBuilder<TEntity> Configure(ComplexPropertyBuilder<TEntity> builder);
+    public void Configure(ComplexPropertyBuilder<TEntity> builder);
 }

src/AStar.Dev.Infrastructure/Data/Configurations/IComplexPropertyConfiguration.cs

@@ -12,7 +12,7 @@ public void ContainTheExpectedProperties()
            .ToJson()
            .ShouldMatchApproved();
 
-    private class MockAuditableEntity : AuditableEntity
+    private sealed class MockAuditableEntity : AuditableEntity
     {
     }
 }

test/AStar.Dev.Infrastructure.Tests.Unit/AuditableEntityShould.cs

@@ -0,0 +1,40 @@
+using AStar.Dev.Infrastructure.Data.Configurations;
+using Microsoft.EntityFrameworkCore;
+using Microsoft.EntityFrameworkCore.Metadata.Builders;
+
+namespace AStar.Dev.Infrastructure.Tests.Unit;
+
+public class ComplexPropertyBuilderConfigurationShould
+{
+    private sealed class DummyEntity
+    {
+        public Address Address { get; set; } = new();
+    }
+
+    private sealed class Address
+    {
+        public string Street { get; set; } = string.Empty;
+    }
+
+    private sealed class TestConfiguration : IComplexPropertyConfiguration<Address>
+    {
+        public bool WasCalled { get; private set; }
+
+        public void Configure(ComplexPropertyBuilder<Address> builder) => WasCalled = true;
+    }
+
+    [Fact]
+    public void Configure_ShouldInvokeConfigurationAndReturnSameBuilder()
+    {
+        var modelBuilder   = new ModelBuilder();
+        var entityBuilder  = modelBuilder.Entity<DummyEntity>();
+        var complexBuilder = entityBuilder.ComplexProperty(e => e.Address);
+
+        var config = new TestConfiguration();
+
+        var result = complexBuilder.Configure(config);
+
+        Assert.True(config.WasCalled);
+        Assert.Same(complexBuilder, result);
+    }
+}