Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Commit 8babf2b

Browse files
committed
Change in-box tag helpers to use DefaultFrameworkSortOrder
- #2905 - override `Order` implementation inherited from `TagHelper` - only exception is `UrlResolutionTagHelper` which already overrides `Order` to execute much earlier
1 parent 4a7ada5 commit 8babf2b

14 files changed

+128
-2
lines changed

src/Microsoft.AspNet.Mvc.TagHelpers/AnchorTagHelper.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,15 @@ public AnchorTagHelper(IHtmlGenerator generator)
4141
Generator = generator;
4242
}
4343

44+
/// <inheritdoc />
45+
public override int Order
46+
{
47+
get
48+
{
49+
return DefaultOrder.DefaultFrameworkSortOrder;
50+
}
51+
}
52+
4453
protected IHtmlGenerator Generator { get; }
4554

4655
/// <summary>

src/Microsoft.AspNet.Mvc.TagHelpers/CacheTagHelper.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,15 @@ public CacheTagHelper(IMemoryCache memoryCache)
4545
MemoryCache = memoryCache;
4646
}
4747

48+
/// <inheritdoc />
49+
public override int Order
50+
{
51+
get
52+
{
53+
return DefaultOrder.DefaultFrameworkSortOrder;
54+
}
55+
}
56+
4857
/// <summary>
4958
/// Gets the <see cref="IMemoryCache"/> instance used to cache entries.
5059
/// </summary>

src/Microsoft.AspNet.Mvc.TagHelpers/EnvironmentTagHelper.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,15 @@ public EnvironmentTagHelper(IHostingEnvironment hostingEnvironment)
2525
HostingEnvironment = hostingEnvironment;
2626
}
2727

28+
/// <inheritdoc />
29+
public override int Order
30+
{
31+
get
32+
{
33+
return DefaultOrder.DefaultFrameworkSortOrder;
34+
}
35+
}
36+
2837
/// <summary>
2938
/// A comma separated list of environment names in which the content should be rendered.
3039
/// </summary>

src/Microsoft.AspNet.Mvc.TagHelpers/FormTagHelper.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,15 @@ public FormTagHelper(IHtmlGenerator generator)
3737
Generator = generator;
3838
}
3939

40+
/// <inheritdoc />
41+
public override int Order
42+
{
43+
get
44+
{
45+
return DefaultOrder.DefaultFrameworkSortOrder;
46+
}
47+
}
48+
4049
[HtmlAttributeNotBound]
4150
[ViewContext]
4251
public ViewContext ViewContext { get; set; }

src/Microsoft.AspNet.Mvc.TagHelpers/ImageTagHelper.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,15 @@ public ImageTagHelper(
4646
Cache = cache;
4747
}
4848

49+
/// <inheritdoc />
50+
public override int Order
51+
{
52+
get
53+
{
54+
return DefaultOrder.DefaultFrameworkSortOrder;
55+
}
56+
}
57+
4958
/// <summary>
5059
/// Source of the image.
5160
/// </summary>

src/Microsoft.AspNet.Mvc.TagHelpers/InputTagHelper.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,15 @@ public InputTagHelper(IHtmlGenerator generator)
7171
Generator = generator;
7272
}
7373

74+
/// <inheritdoc />
75+
public override int Order
76+
{
77+
get
78+
{
79+
return DefaultOrder.DefaultFrameworkSortOrder;
80+
}
81+
}
82+
7483
protected IHtmlGenerator Generator { get; }
7584

7685
[HtmlAttributeNotBound]

src/Microsoft.AspNet.Mvc.TagHelpers/LabelTagHelper.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,15 @@ public LabelTagHelper(IHtmlGenerator generator)
2424
Generator = generator;
2525
}
2626

27+
/// <inheritdoc />
28+
public override int Order
29+
{
30+
get
31+
{
32+
return DefaultOrder.DefaultFrameworkSortOrder;
33+
}
34+
}
35+
2736
[HtmlAttributeNotBound]
2837
[ViewContext]
2938
public ViewContext ViewContext { get; set; }

src/Microsoft.AspNet.Mvc.TagHelpers/LinkTagHelper.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,15 @@ public LinkTagHelper(
107107
JavaScriptEncoder = javaScriptEncoder;
108108
}
109109

110+
/// <inheritdoc />
111+
public override int Order
112+
{
113+
get
114+
{
115+
return DefaultOrder.DefaultFrameworkSortOrder;
116+
}
117+
}
118+
110119
/// <summary>
111120
/// Address of the linked resource.
112121
/// </summary>

src/Microsoft.AspNet.Mvc.TagHelpers/OptionTagHelper.cs

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ namespace Microsoft.AspNet.Mvc.TagHelpers
1313
/// <see cref="ITagHelper"/> implementation targeting &lt;option&gt; elements.
1414
/// </summary>
1515
/// <remarks>
16-
/// This <see cref="ITagHelper"/> works in conjunction with <see cref="SelectTagHelper"/>. It reads elements
17-
/// content but does not modify that content. The only modification it makes is to add a <c>selected</c> attribute
16+
/// This <see cref="ITagHelper"/> works in conjunction with <see cref="SelectTagHelper"/>. It reads elements
17+
/// content but does not modify that content. The only modification it makes is to add a <c>selected</c> attribute
1818
/// in some cases.
1919
/// </remarks>
2020
public class OptionTagHelper : TagHelper
@@ -28,6 +28,15 @@ public OptionTagHelper(IHtmlGenerator generator)
2828
Generator = generator;
2929
}
3030

31+
/// <inheritdoc />
32+
public override int Order
33+
{
34+
get
35+
{
36+
return DefaultOrder.DefaultFrameworkSortOrder;
37+
}
38+
}
39+
3140
protected IHtmlGenerator Generator { get; }
3241

3342
[HtmlAttributeNotBound]

src/Microsoft.AspNet.Mvc.TagHelpers/ScriptTagHelper.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,15 @@ public ScriptTagHelper(
9393
JavaScriptEncoder = javaScriptEncoder;
9494
}
9595

96+
/// <inheritdoc />
97+
public override int Order
98+
{
99+
get
100+
{
101+
return DefaultOrder.DefaultFrameworkSortOrder;
102+
}
103+
}
104+
96105
/// <summary>
97106
/// Address of the external script to use.
98107
/// </summary>

0 commit comments

Comments
 (0)