Add UseMonoRuntime_LlvmJit option #1533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienros
reviewed
Jun 1, 2020
SamMonoRT
reviewed
Jun 2, 2020
| packageName = "Microsoft.NETCore.App.Runtime.Mono.linux-x64".ToLowerInvariant(); | ||
| break; | ||
| case "llvm-jit": | ||
| packageName = "Microsoft.NETCore.App.Runtime.Mono.LLVM.AOT.linux-x64".ToLowerInvariant(); |
There was a problem hiding this comment.
Is this right or should we use the LLVM.JIT package ? Seems confusing
Contributor
Author
There was a problem hiding this comment.
We don't have the LLVM.JIT package. For some reason, they never got generated. The literal only difference between the AOT LLVM and JIT LLVM packages are the AOT packages also contain llc/opt. So it is totally fine to use the AOT LLVM package for JIT LLVM.
Member
|
LGTM. Have you tested the changes for the server? |
Contributor
Author
Yes, I've tested this change on Mono lab machines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to support netcore Mono with LLVM JIT