From 7b3448190c0b623f956ba31f1d2e3f73cd57b277 Mon Sep 17 00:00:00 2001 From: Trevor Ackerman Date: Thu, 23 Oct 2025 17:34:59 -0600 Subject: [PATCH 1/4] Fix problem with regular expression to grab go version from go.mod --- bin/parse-legacy-file | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/parse-legacy-file b/bin/parse-legacy-file index c6f0e13..411b84f 100755 --- a/bin/parse-legacy-file +++ b/bin/parse-legacy-file @@ -34,7 +34,7 @@ get_legacy_version() { sed -E \ -e 's/.*heroku goVersion //' \ -e 's/[[:space:]]//' \ - -e 's/go([0-9]+).*/\1/' | + -e 's/go([0-9]+.).*/\1/' | head -1 ) elif [ -e "$current_file" ]; then From a1155f47b037cf94f30305b058be6efb1481dae3 Mon Sep 17 00:00:00 2001 From: Trevor Ackerman Date: Fri, 24 Oct 2025 09:28:07 -0600 Subject: [PATCH 2/4] improve go version regex --- bin/parse-legacy-file | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/parse-legacy-file b/bin/parse-legacy-file index 411b84f..dcd3c1a 100755 --- a/bin/parse-legacy-file +++ b/bin/parse-legacy-file @@ -34,7 +34,7 @@ get_legacy_version() { sed -E \ -e 's/.*heroku goVersion //' \ -e 's/[[:space:]]//' \ - -e 's/go([0-9]+.).*/\1/' | + -e 's/go([1-9][[:digit:]]*\.[[:digit:]]+\.[[:digit:]]+)/\1/' | head -1 ) elif [ -e "$current_file" ]; then From d9c24ecbbe4cf21d72ca7fac218bd782eac3e73c Mon Sep 17 00:00:00 2001 From: Trevor Ackerman Date: Fri, 24 Oct 2025 09:35:56 -0600 Subject: [PATCH 3/4] allow patch version to be optional --- bin/parse-legacy-file | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/parse-legacy-file b/bin/parse-legacy-file index dcd3c1a..4c1af63 100755 --- a/bin/parse-legacy-file +++ b/bin/parse-legacy-file @@ -34,7 +34,7 @@ get_legacy_version() { sed -E \ -e 's/.*heroku goVersion //' \ -e 's/[[:space:]]//' \ - -e 's/go([1-9][[:digit:]]*\.[[:digit:]]+\.[[:digit:]]+)/\1/' | + -e 's/go([1-9][[:digit:]]*\.[[:digit:]]+(\.[[:digit:]]+)?)/\1/' | head -1 ) elif [ -e "$current_file" ]; then From 245907fc8cc24d6ab983b044ee2105db0d112454 Mon Sep 17 00:00:00 2001 From: Trevor Ackerman Date: Fri, 24 Oct 2025 09:43:06 -0600 Subject: [PATCH 4/4] parse legacy file should return highest patch version from go.mod match --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 93537fe..64fabe4 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -29,7 +29,7 @@ jobs: - name: Test parsing 'go.mod' run: | - bin/parse-legacy-file test-fixtures/go.mod | grep "^1.19.3" + bin/parse-legacy-file test-fixtures/go.mod | grep "^1.18.6" - name: Test parsing '.go-version' run: | bin/parse-legacy-file test-fixtures/.go-version | grep "^1.17.13"