Skip to content

Fix crash #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Fix crash #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f62f9ca
Fix type checker crash
andrewbranch Sep 5, 2023
ae2426f
Add changeset
andrewbranch Sep 5, 2023
335c13f
Actually commit the fix
andrewbranch Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/rude-olives-tease.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@arethetypeswrong/core": patch
---

Fixed bug that could cause a crash while checking for FalseExportDefault
6 changes: 1 addition & 5 deletions packages/core/src/checks/entrypointResolutionProblems.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,7 @@ export function getEntrypointResolutionProblems(
})
.getTypeChecker();
// Check for `default` property on `jsModule["export="]`
if (
!jsChecker
.getExportsAndPropertiesOfModule(jsChecker.resolveExternalModuleSymbol(jsSourceFile.symbol))
.some((s) => s.name === "default")
) {
if (!jsChecker.getExportsAndPropertiesOfModule(jsSourceFile.symbol).some((s) => s.name === "default")) {
problems.push({
kind: "FalseExportDefault",
entrypoint: subpath,
Expand Down
Binary file added packages/core/test/fixtures/@[email protected]
View file
Open in desktop
Binary file not shown.
Loading