Skip to content

Commit ec54e9a

Browse files
committed
Don’t run MissingExportEquals on ESM implementation files
1 parent b596e74 commit ec54e9a

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

packages/core/src/internal/checks/exportDefaultDisagreement.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export default defineCheck({
4646
}
4747
const implementationSourceFile = host.getSourceFile(implementationFileName)!;
4848
ts.bindSourceFile(implementationSourceFile, bindOptions);
49-
if (!implementationSourceFile.symbol?.exports) {
49+
if (!implementationSourceFile.symbol?.exports || implementationSourceFile.externalModuleIndicator) {
5050
return;
5151
}
5252

packages/core/test/problems/exportDefaultDisagreement.test.ts

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -262,4 +262,22 @@ var index_default = { a, b };`,
262262
),
263263
);
264264
});
265+
266+
test("does not run on ESM", () => {
267+
assert(
268+
isOk(
269+
`export * from 'foo';
270+
declare const _default: { Type: string, Schema: string };
271+
export default _default;`,
272+
`var Type = "Type";
273+
var Schema = "Schema";
274+
var jsYaml = {
275+
Type,
276+
Schema
277+
};
278+
export default jsYaml;
279+
export { Type, Schema };`,
280+
),
281+
);
282+
});
265283
});

0 commit comments

Comments
 (0)