File tree Expand file tree Collapse file tree 1 file changed +7
-0
lines changed
packages/core/src/internal/checks Expand file tree Collapse file tree 1 file changed +7
-0
lines changed Original file line number Diff line number Diff line change @@ -28,6 +28,13 @@ export default defineCheck({
2828 return [ typesFileName , implementationFileName ] ;
2929 } ,
3030 execute : ( [ typesFileName , implementationFileName ] , context ) => {
31+ // Technically, much of this implementation should go in `dependencies`, since
32+ // different resolution modes can result in different program graphs, resulting
33+ // in different types, which are queried heavily here. However, it would be much
34+ // more expensive to run this type-heavy code in `dependencies`, where it would
35+ // reevaluate for every entrypoint/resolution matrix cell, when chances are
36+ // extremely high that a given pair of types/implementation files are intended
37+ // to act the same under all resolution modes.
3138 if ( ! typesFileName || ! implementationFileName || ! ts . hasTSFileExtension ( typesFileName ) ) {
3239 return ;
3340 }
You can’t perform that action at this time.
0 commit comments