Dedupe files for ResolutionBasedFileProblems

Author: andrewbranch

packages/cli/test/snapshots/@[email protected]

@@ -0,0 +1,30 @@
+# @[email protected]
+
+```
+$ attw @[email protected]
+
+
+⚠️ A require call resolved to an ESM JavaScript file, which is an error in Node and some bundlers. CommonJS consumers will need to use a dynamic import. https://github.com/arethetypeswrong/arethetypeswrong.github.io/blob/main/docs/problems/CJSResolvesToESM.md
+
+💀 Import failed to resolve to type declarations or JavaScript files. https://github.com/arethetypeswrong/arethetypeswrong.github.io/blob/main/docs/problems/NoResolution.md
+
+🥴 Import found in a type declaration file failed to resolve. Either this indicates that runtime resolution errors will occur, or (more likely) the types misrepresent the contents of the JavaScript files. https://github.com/arethetypeswrong/arethetypeswrong.github.io/blob/main/docs/problems/InternalResolutionError.md
+
+
+┌────────────────────┬───────────────────────────────────┬───────────────────────────────────┬───────────────────────────────────┐
+│                    │ "@ice/app"                        │ "@ice/app/types"                  │ "@ice/app/analyze"                │
+├────────────────────┼───────────────────────────────────┼───────────────────────────────────┼───────────────────────────────────┤
+│ node10             │ 🟢                                │ 🟢                                │ 💀 Resolution failed              │
+├────────────────────┼───────────────────────────────────┼───────────────────────────────────┼───────────────────────────────────┤
+│ node16 (from CJS)  │ ⚠️ ESM (dynamic import only)      │ ⚠️ ESM (dynamic import only)      │ ⚠️ ESM (dynamic import only)      │
+│                    │ 🥴 Internal resolution error      │ 🥴 Internal resolution error      │                                   │
+├────────────────────┼───────────────────────────────────┼───────────────────────────────────┼───────────────────────────────────┤
+│ node16 (from ESM)  │ 🥴 Internal resolution error      │ 🥴 Internal resolution error      │ 🟢 (ESM)                          │
+├────────────────────┼───────────────────────────────────┼───────────────────────────────────┼───────────────────────────────────┤
+│ bundler            │ 🟢                                │ 🟢                                │ 🟢                                │
+└────────────────────┴───────────────────────────────────┴───────────────────────────────────┴───────────────────────────────────┘
+
+
+```
+
+Exit code: 1

packages/core/src/checks/resolutionBasedFileProblems.ts

@@ -10,16 +10,18 @@ export function getResolutionBasedFileProblems(
 ): ResolutionBasedFileProblem[] {
   const result: ResolutionBasedFileProblem[] = [];
   for (const resolutionOption of allResolutionOptions) {
-    const visibleFiles = Object.values(entrypointResolutions).flatMap((entrypoint) => {
-      const files = new Set<string>();
-      getResolutionKinds(resolutionOption).forEach((resolutionKind) => {
-        entrypoint.resolutions[resolutionKind].files?.forEach((file) => files.add(file));
-        if (entrypoint.resolutions[resolutionKind].implementationResolution) {
-          files.add(entrypoint.resolutions[resolutionKind].implementationResolution!.fileName);
-        }
-      });
-      return Array.from(files);
-    });
+    const visibleFiles = new Set(
+      Object.values(entrypointResolutions).flatMap((entrypoint) => {
+        const files = new Set<string>();
+        getResolutionKinds(resolutionOption).forEach((resolutionKind) => {
+          entrypoint.resolutions[resolutionKind].files?.forEach((file) => files.add(file));
+          if (entrypoint.resolutions[resolutionKind].implementationResolution) {
+            files.add(entrypoint.resolutions[resolutionKind].implementationResolution!.fileName);
+          }
+        });
+        return Array.from(files);
+      })
+    );
 
     for (const fileName of visibleFiles) {
       const sourceFile = host.getSourceFile(fileName, resolutionOption)!;
@@ -46,13 +48,11 @@ export function getResolutionBasedFileProblems(
               kind: "InternalResolutionError",
               resolutionOption,
               fileName,
-              error: {
-                moduleSpecifier: reference,
-                pos: moduleSpecifier.pos,
-                end: moduleSpecifier.end,
-                resolutionMode,
-                trace: host.getTrace(resolutionOption, fileName, moduleSpecifier.text, resolutionMode)!,
-              },
+              moduleSpecifier: reference,
+              pos: moduleSpecifier.pos,
+              end: moduleSpecifier.end,
+              resolutionMode,
+              trace: host.getTrace(resolutionOption, fileName, moduleSpecifier.text, resolutionMode)!,
             });
           }
         }

packages/core/src/types.ts

@@ -61,14 +61,6 @@ export interface Resolution {
   trace: string[];
 }
 
-export interface InternalResolutionErrorDetails {
-  pos: number;
-  end: number;
-  moduleSpecifier: string;
-  resolutionMode: ts.ModuleKind.ESNext | ts.ModuleKind.CommonJS | undefined;
-  trace: string[];
-}
-
 export type EntrypointResolutionProblemKind =
   | "NoResolution"
   | "UntypedResolution"
@@ -89,7 +81,11 @@ export interface InternalResolutionProblem {
   kind: "InternalResolutionError";
   resolutionOption: ResolutionOption;
   fileName: string;
-  error: InternalResolutionErrorDetails;
+  pos: number;
+  end: number;
+  moduleSpecifier: string;
+  resolutionMode: ts.ResolutionMode;
+  trace: string[];
 }
 
 export interface UnexpectedModuleSyntaxProblem {

packages/core/test/fixtures/@[email protected]

@@ -0,0 +1,61 @@
+# @[email protected]
+
+## Problems
+
+```json
+[
+  {
+    "kind": "CJSResolvesToESM",
+    "entrypoint": ".",
+    "resolutionKind": "node16-cjs"
+  },
+  {
+    "kind": "CJSResolvesToESM",
+    "entrypoint": "./types",
+    "resolutionKind": "node16-cjs"
+  },
+  {
+    "kind": "NoResolution",
+    "entrypoint": "./analyze",
+    "resolutionKind": "node10"
+  },
+  {
+    "kind": "CJSResolvesToESM",
+    "entrypoint": "./analyze",
+    "resolutionKind": "node16-cjs"
+  },
+  {
+    "kind": "InternalResolutionError",
+    "resolutionOption": "node16",
+    "fileName": "/node_modules/@ice/app/esm/types/userConfig.d.ts",
+    "moduleSpecifier": "./plugin",
+    "pos": 391,
+    "end": 402,
+    "resolutionMode": 99,
+    "trace": [
+      "======== Resolving module './plugin' from '/node_modules/@ice/app/esm/types/userConfig.d.ts'. ========",
+      "Explicitly specified module resolution kind: 'Node16'.",
+      "Resolving in ESM mode with conditions 'import', 'types', 'node'.",
+      "Loading module as file / folder, candidate module location '/node_modules/@ice/app/esm/types/plugin', target file types: TypeScript, JavaScript, Declaration, JSON.",
+      "Directory '/node_modules/@ice/app/esm/types/plugin' does not exist, skipping all lookups in it.",
+      "======== Module name './plugin' was not resolved. ========"
+    ]
+  },
+  {
+    "kind": "InternalResolutionError",
+    "resolutionOption": "node16",
+    "fileName": "/node_modules/@ice/app/esm/index.d.ts",
+    "moduleSpecifier": "./types",
+    "pos": 81,
+    "end": 91,
+    "resolutionMode": 99,
+    "trace": [
+      "======== Resolving module './types' from '/node_modules/@ice/app/esm/index.d.ts'. ========",
+      "Explicitly specified module resolution kind: 'Node16'.",
+      "Resolving in ESM mode with conditions 'import', 'types', 'node'.",
+      "Loading module as file / folder, candidate module location '/node_modules/@ice/app/esm/types', target file types: TypeScript, JavaScript, Declaration, JSON.",
+      "======== Module name './types' was not resolved. ========"
+    ]
+  }
+]
+```