Don’t rely on npm pack STDOUT to get tarball filename

andrewbranch · andrewbranch · commit 662a6e19209a · 2023-12-03T10:27:19.000-08:00
diff --git a/packages/cli/src/index.ts b/packages/cli/src/index.ts
@@ -171,10 +171,13 @@ particularly ESM-related module resolution issues.`,
             }
           }
 
-          fileName = deleteTgz = path.resolve(
+          const manifest = JSON.parse(await readFile(path.join(fileOrDirectory, "package.json"), { encoding: "utf8" }));
+          fileName = deleteTgz = path.join(
             fileOrDirectory,
-            execSync("npm pack", { cwd: fileOrDirectory, encoding: "utf8", stdio: "pipe" }).trim(),
+            // https://github.com/npm/cli/blob/f875caa86900122819311dd77cde01c700fd1817/lib/utils/tar.js#L123-L125
+            `${manifest.name.replace("@", "").replace("/", "-")}-${manifest.version}.tgz`,
           );
+          execSync("npm pack", { cwd: fileOrDirectory, encoding: "utf8", stdio: "ignore" });
         }
         const file = await readFile(fileName);
         const data = new Uint8Array(file);

Original file line number	Diff line number	Diff line change
@@ -171,10 +171,13 @@ particularly ESM-related module resolution issues.`,
`171`	`171`	`}`
`172`	`172`	`}`
`173`	`173`
`174`		`- fileName = deleteTgz = path.resolve(`
	`174`	`+ const manifest = JSON.parse(await readFile(path.join(fileOrDirectory, "package.json"), { encoding: "utf8" }));`
	`175`	`+ fileName = deleteTgz = path.join(`
`175`	`176`	`fileOrDirectory,`
`176`		`- execSync("npm pack", { cwd: fileOrDirectory, encoding: "utf8", stdio: "pipe" }).trim(),`
	`177`	`+ // https://github.com/npm/cli/blob/f875caa86900122819311dd77cde01c700fd1817/lib/utils/tar.js#L123-L125`
	`178`	+ `${manifest.name.replace("@", "").replace("/", "-")}-${manifest.version}.tgz`,
`177`	`179`	`);`
	`180`	`+ execSync("npm pack", { cwd: fileOrDirectory, encoding: "utf8", stdio: "ignore" });`
`178`	`181`	`}`
`179`	`182`	`const file = await readFile(fileName);`
`180`	`183`	`const data = new Uint8Array(file);`