Skip to content

Commit b5079ce

Browse files
committed
rename DocumentRequest to DocumentWriteRequest
1 parent eee0d18 commit b5079ce

33 files changed

+134
-165
lines changed

client/client-benchmark-noop-api-plugin/src/main/java/org/elasticsearch/plugin/noop/action/bulk/RestNoopBulkAction.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
package org.elasticsearch.plugin.noop.action.bulk;
2020

2121
import org.elasticsearch.action.DocWriteResponse;
22-
import org.elasticsearch.action.DocumentRequest;
22+
import org.elasticsearch.action.DocumentWriteRequest;
2323
import org.elasticsearch.action.bulk.BulkItemResponse;
2424
import org.elasticsearch.action.bulk.BulkRequest;
2525
import org.elasticsearch.action.bulk.BulkShardRequest;
@@ -85,7 +85,7 @@ public RestChannelConsumer prepareRequest(final RestRequest request, final NodeC
8585
}
8686

8787
private static class BulkRestBuilderListener extends RestBuilderListener<BulkRequest> {
88-
private final BulkItemResponse ITEM_RESPONSE = new BulkItemResponse(1, DocumentRequest.OpType.UPDATE,
88+
private final BulkItemResponse ITEM_RESPONSE = new BulkItemResponse(1, DocumentWriteRequest.OpType.UPDATE,
8989
new UpdateResponse(new ShardId("mock", "", 1), "mock_type", "1", 1L, DocWriteResponse.Result.CREATED));
9090

9191
private final RestRequest request;

client/client-benchmark-noop-api-plugin/src/main/java/org/elasticsearch/plugin/noop/action/bulk/TransportNoopBulkAction.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
import org.elasticsearch.action.ActionListener;
2222
import org.elasticsearch.action.DocWriteResponse;
23-
import org.elasticsearch.action.DocumentRequest;
23+
import org.elasticsearch.action.DocumentWriteRequest;
2424
import org.elasticsearch.action.bulk.BulkItemResponse;
2525
import org.elasticsearch.action.bulk.BulkRequest;
2626
import org.elasticsearch.action.bulk.BulkResponse;
@@ -35,7 +35,7 @@
3535
import org.elasticsearch.transport.TransportService;
3636

3737
public class TransportNoopBulkAction extends HandledTransportAction<BulkRequest, BulkResponse> {
38-
private static final BulkItemResponse ITEM_RESPONSE = new BulkItemResponse(1, DocumentRequest.OpType.UPDATE,
38+
private static final BulkItemResponse ITEM_RESPONSE = new BulkItemResponse(1, DocumentWriteRequest.OpType.UPDATE,
3939
new UpdateResponse(new ShardId("mock", "", 1), "mock_type", "1", 1L, DocWriteResponse.Result.CREATED));
4040

4141
@Inject

core/src/main/java/org/elasticsearch/action/DocumentRequest.java renamed to core/src/main/java/org/elasticsearch/action/DocumentWriteRequest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
* Generic interface to group ActionRequest, which perform writes to a single document
3535
* Action requests implementing this can be part of {@link org.elasticsearch.action.bulk.BulkRequest}
3636
*/
37-
public abstract class DocumentRequest<T extends ReplicatedWriteRequest<T>> extends ReplicatedWriteRequest<T> {
37+
public abstract class DocumentWriteRequest<T extends ReplicatedWriteRequest<T>> extends ReplicatedWriteRequest<T> {
3838

3939
/**
4040
* Get the type that this request operates on
@@ -153,7 +153,7 @@ public static OpType fromString(String sOpType) {
153153
}
154154

155155
/** read a document write (index/delete/update) request */
156-
public static DocumentRequest readDocumentRequest(StreamInput in) throws IOException {
156+
public static DocumentWriteRequest readDocumentRequest(StreamInput in) throws IOException {
157157
byte type = in.readByte();
158158
if (type == 0) {
159159
IndexRequest indexRequest = new IndexRequest();
@@ -177,7 +177,7 @@ public static DocumentRequest readDocumentRequest(StreamInput in) throws IOExcep
177177
}
178178

179179
/** write a document write (index/delete/update) request*/
180-
public static void writeDocumentRequest(StreamOutput out, DocumentRequest request) throws IOException {
180+
public static void writeDocumentRequest(StreamOutput out, DocumentWriteRequest request) throws IOException {
181181
if (request instanceof IndexRequest) {
182182
out.writeByte((byte) 0);
183183
} else if (request instanceof DeleteRequest) {

core/src/main/java/org/elasticsearch/action/bulk/BulkItemRequest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
package org.elasticsearch.action.bulk;
2121

22-
import org.elasticsearch.action.DocumentRequest;
22+
import org.elasticsearch.action.DocumentWriteRequest;
2323
import org.elasticsearch.common.io.stream.StreamInput;
2424
import org.elasticsearch.common.io.stream.StreamOutput;
2525
import org.elasticsearch.common.io.stream.Streamable;
@@ -32,15 +32,15 @@
3232
public class BulkItemRequest implements Streamable {
3333

3434
private int id;
35-
private DocumentRequest<?> request;
35+
private DocumentWriteRequest<?> request;
3636
private volatile BulkItemResponse primaryResponse;
3737
private volatile boolean ignoreOnReplica;
3838

3939
BulkItemRequest() {
4040

4141
}
4242

43-
public BulkItemRequest(int id, DocumentRequest<?> request) {
43+
public BulkItemRequest(int id, DocumentWriteRequest<?> request) {
4444
this.id = id;
4545
this.request = request;
4646
}
@@ -49,7 +49,7 @@ public int id() {
4949
return id;
5050
}
5151

52-
public DocumentRequest<?> request() {
52+
public DocumentWriteRequest<?> request() {
5353
return request;
5454
}
5555

@@ -86,7 +86,7 @@ public static BulkItemRequest readBulkItem(StreamInput in) throws IOException {
8686
@Override
8787
public void readFrom(StreamInput in) throws IOException {
8888
id = in.readVInt();
89-
request = DocumentRequest.readDocumentRequest(in);
89+
request = DocumentWriteRequest.readDocumentRequest(in);
9090
if (in.readBoolean()) {
9191
primaryResponse = BulkItemResponse.readBulkItem(in);
9292
}
@@ -96,7 +96,7 @@ public void readFrom(StreamInput in) throws IOException {
9696
@Override
9797
public void writeTo(StreamOutput out) throws IOException {
9898
out.writeVInt(id);
99-
DocumentRequest.writeDocumentRequest(out, request);
99+
DocumentWriteRequest.writeDocumentRequest(out, request);
100100
out.writeOptionalStreamable(primaryResponse);
101101
out.writeBoolean(ignoreOnReplica);
102102
}

core/src/main/java/org/elasticsearch/action/bulk/BulkItemResponse.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import org.elasticsearch.ExceptionsHelper;
2424
import org.elasticsearch.Version;
2525
import org.elasticsearch.action.DocWriteResponse;
26-
import org.elasticsearch.action.DocumentRequest.OpType;
26+
import org.elasticsearch.action.DocumentWriteRequest.OpType;
2727
import org.elasticsearch.action.delete.DeleteResponse;
2828
import org.elasticsearch.action.index.IndexResponse;
2929
import org.elasticsearch.action.update.UpdateResponse;

core/src/main/java/org/elasticsearch/action/bulk/BulkProcessor.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
package org.elasticsearch.action.bulk;
2121

22-
import org.elasticsearch.action.DocumentRequest;
22+
import org.elasticsearch.action.DocumentWriteRequest;
2323
import org.elasticsearch.action.delete.DeleteRequest;
2424
import org.elasticsearch.action.index.IndexRequest;
2525
import org.elasticsearch.client.Client;
@@ -250,24 +250,24 @@ public synchronized boolean awaitClose(long timeout, TimeUnit unit) throws Inter
250250
* (for example, if no id is provided, one will be generated, or usage of the create flag).
251251
*/
252252
public BulkProcessor add(IndexRequest request) {
253-
return add((DocumentRequest<?>) request);
253+
return add((DocumentWriteRequest<?>) request);
254254
}
255255

256256
/**
257257
* Adds an {@link DeleteRequest} to the list of actions to execute.
258258
*/
259259
public BulkProcessor add(DeleteRequest request) {
260-
return add((DocumentRequest<?>) request);
260+
return add((DocumentWriteRequest<?>) request);
261261
}
262262

263263
/**
264264
* Adds either a delete or an index request.
265265
*/
266-
public BulkProcessor add(DocumentRequest<?> request) {
266+
public BulkProcessor add(DocumentWriteRequest<?> request) {
267267
return add(request, null);
268268
}
269269

270-
public BulkProcessor add(DocumentRequest<?> request, @Nullable Object payload) {
270+
public BulkProcessor add(DocumentWriteRequest<?> request, @Nullable Object payload) {
271271
internalAdd(request, payload);
272272
return this;
273273
}
@@ -282,7 +282,7 @@ protected void ensureOpen() {
282282
}
283283
}
284284

285-
private synchronized void internalAdd(DocumentRequest<?> request, @Nullable Object payload) {
285+
private synchronized void internalAdd(DocumentWriteRequest<?> request, @Nullable Object payload) {
286286
ensureOpen();
287287
bulkRequest.add(request, payload);
288288
executeIfNeeded();

core/src/main/java/org/elasticsearch/action/bulk/BulkRequest.java

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
import org.elasticsearch.action.ActionRequest;
2323
import org.elasticsearch.action.ActionRequestValidationException;
2424
import org.elasticsearch.action.CompositeIndicesRequest;
25-
import org.elasticsearch.action.DocumentRequest;
25+
import org.elasticsearch.action.DocumentWriteRequest;
2626
import org.elasticsearch.action.IndicesRequest;
2727
import org.elasticsearch.action.delete.DeleteRequest;
2828
import org.elasticsearch.action.index.IndexRequest;
@@ -72,7 +72,7 @@ public class BulkRequest extends ActionRequest<BulkRequest> implements Composite
7272
* {@link WriteRequest}s to this but java doesn't support syntax to declare that everything in the array has both types so we declare
7373
* the one with the least casts.
7474
*/
75-
final List<DocumentRequest<?>> requests = new ArrayList<>();
75+
final List<DocumentWriteRequest<?>> requests = new ArrayList<>();
7676
List<Object> payloads = null;
7777

7878
protected TimeValue timeout = BulkShardRequest.DEFAULT_TIMEOUT;
@@ -87,14 +87,14 @@ public BulkRequest() {
8787
/**
8888
* Adds a list of requests to be executed. Either index or delete requests.
8989
*/
90-
public BulkRequest add(DocumentRequest<?>... requests) {
91-
for (DocumentRequest<?> request : requests) {
90+
public BulkRequest add(DocumentWriteRequest<?>... requests) {
91+
for (DocumentWriteRequest<?> request : requests) {
9292
add(request, null);
9393
}
9494
return this;
9595
}
9696

97-
public BulkRequest add(DocumentRequest<?> request) {
97+
public BulkRequest add(DocumentWriteRequest<?> request) {
9898
return add(request, null);
9999
}
100100

@@ -104,7 +104,7 @@ public BulkRequest add(DocumentRequest<?> request) {
104104
* @param payload Optional payload
105105
* @return the current bulk request
106106
*/
107-
public BulkRequest add(DocumentRequest<?> request, @Nullable Object payload) {
107+
public BulkRequest add(DocumentWriteRequest<?> request, @Nullable Object payload) {
108108
if (request instanceof IndexRequest) {
109109
add((IndexRequest) request, payload);
110110
} else if (request instanceof DeleteRequest) {
@@ -120,8 +120,8 @@ public BulkRequest add(DocumentRequest<?> request, @Nullable Object payload) {
120120
/**
121121
* Adds a list of requests to be executed. Either index or delete requests.
122122
*/
123-
public BulkRequest add(Iterable<DocumentRequest<?>> requests) {
124-
for (DocumentRequest<?> request : requests) {
123+
public BulkRequest add(Iterable<DocumentWriteRequest<?>> requests) {
124+
for (DocumentWriteRequest<?> request : requests) {
125125
add(request);
126126
}
127127
return this;
@@ -207,7 +207,7 @@ private void addPayload(Object payload) {
207207
/**
208208
* The list of requests in this bulk request.
209209
*/
210-
public List<DocumentRequest<?>> requests() {
210+
public List<DocumentWriteRequest<?>> requests() {
211211
return this.requests;
212212
}
213213

@@ -508,7 +508,7 @@ private int findNextMarker(byte marker, int from, BytesReference data, int lengt
508508
* @return Whether this bulk request contains index request with an ingest pipeline enabled.
509509
*/
510510
public boolean hasIndexRequestsWithPipelines() {
511-
for (DocumentRequest<?> actionRequest : requests) {
511+
for (DocumentWriteRequest<?> actionRequest : requests) {
512512
if (actionRequest instanceof IndexRequest) {
513513
IndexRequest indexRequest = (IndexRequest) actionRequest;
514514
if (Strings.hasText(indexRequest.getPipeline())) {
@@ -526,7 +526,7 @@ public ActionRequestValidationException validate() {
526526
if (requests.isEmpty()) {
527527
validationException = addValidationError("no requests added", validationException);
528528
}
529-
for (DocumentRequest<?> request : requests) {
529+
for (DocumentWriteRequest<?> request : requests) {
530530
// We first check if refresh has been set
531531
if (request.getRefreshPolicy() != RefreshPolicy.NONE) {
532532
validationException = addValidationError(
@@ -550,7 +550,7 @@ public void readFrom(StreamInput in) throws IOException {
550550
waitForActiveShards = ActiveShardCount.readFrom(in);
551551
int size = in.readVInt();
552552
for (int i = 0; i < size; i++) {
553-
requests.add(DocumentRequest.readDocumentRequest(in));
553+
requests.add(DocumentWriteRequest.readDocumentRequest(in));
554554
}
555555
refreshPolicy = RefreshPolicy.readFrom(in);
556556
timeout = new TimeValue(in);
@@ -561,8 +561,8 @@ public void writeTo(StreamOutput out) throws IOException {
561561
super.writeTo(out);
562562
waitForActiveShards.writeTo(out);
563563
out.writeVInt(requests.size());
564-
for (DocumentRequest<?> request : requests) {
565-
DocumentRequest.writeDocumentRequest(out, request);
564+
for (DocumentWriteRequest<?> request : requests) {
565+
DocumentWriteRequest.writeDocumentRequest(out, request);
566566
}
567567
refreshPolicy.writeTo(out);
568568
timeout.writeTo(out);

0 commit comments

Comments
 (0)