Clean up temporary files on exit (#159)

* Clean up temporary files on exit

Temporary files and directories created when the index is downloaded are now correctly cleaned up on exit.

* Add test to check if `fwuploader` dir is correctly removed on exit

Author: MatteoPologruto

indexes/download/download.go

@@ -229,7 +229,7 @@ func DownloadIndex(indexURL string) (*paths.Path, error) {
 	if err != nil {
 		return nil, err
 	}
-	defer tempDir.Remove()
+	defer tempDir.RemoveAll()
 
 	// Download index
 	tmpGZIndex := tempDir.Join("index.gz")

indexes/indexes.go

@@ -89,6 +89,7 @@ func GetPackageIndex() (*packageindex.Index, error) {
 
 // GetFirmwareIndex downloads and loads the arduino-fwuploader module_firmware_index.json
 func GetFirmwareIndex() (*firmwareindex.Index, error) {
+	defer globals.FwUploaderPath.RemoveAll()
 	indexPath, err := download.DownloadIndex(globals.ModuleFirmwareIndexGZURL)
 	if err != nil {
 		logrus.Error(err)

indexes/indexes_test.go

@@ -22,6 +22,7 @@ import (
 	"testing"
 
 	"github.com/arduino/arduino-cli/arduino/cores/packageindex"
+	"github.com/arduino/arduino-fwuploader/cli/globals"
 	"github.com/arduino/go-paths-helper"
 	"github.com/stretchr/testify/require"
 )
@@ -47,4 +48,5 @@ func TestGetFirmwareIndex(t *testing.T) {
 	index, err := GetFirmwareIndex()
 	require.NoError(t, err)
 	require.NotNil(t, index)
+	require.NoDirExists(t, globals.FwUploaderPath.String())
 }