From 5e220dc134330ba1dd1734c5fce0d3f12f02f4a4 Mon Sep 17 00:00:00 2001 From: Cristian Maglie Date: Mon, 13 Nov 2023 17:36:08 +0100 Subject: [PATCH 1/2] Removed useless file filter --- arduino/builder/internal/utils/utils.go | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/arduino/builder/internal/utils/utils.go b/arduino/builder/internal/utils/utils.go index efd40b307ea..8e7447946db 100644 --- a/arduino/builder/internal/utils/utils.go +++ b/arduino/builder/internal/utils/utils.go @@ -160,17 +160,6 @@ func filterOutSCCS(file *paths.Path) bool { return !sourceControlFolders[file.Base()] } -// filterReadableFiles is a ReadDirFilter that accepts only readable files -func filterReadableFiles(file *paths.Path) bool { - // See if the file is readable by opening it - f, err := file.Open() - if err != nil { - return false - } - f.Close() - return true -} - // filterOutHiddenFiles is a ReadDirFilter that exclude files with a "." prefix in their name var filterOutHiddenFiles = paths.FilterOutPrefixes(".") @@ -180,7 +169,6 @@ func FindFilesInFolder(dir *paths.Path, recurse bool, extensions ...string) (pat filterOutHiddenFiles, filterOutSCCS, paths.FilterOutDirectories(), - filterReadableFiles, ) if len(extensions) > 0 { fileFilter = paths.AndFilter( From 490068f5edd7b8148db908d963a1d4c96f4fac11 Mon Sep 17 00:00:00 2001 From: Cristian Maglie Date: Mon, 13 Nov 2023 17:36:17 +0100 Subject: [PATCH 2/2] Removed unused variable --- arduino/builder/internal/utils/utils.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/arduino/builder/internal/utils/utils.go b/arduino/builder/internal/utils/utils.go index 8e7447946db..8746623a821 100644 --- a/arduino/builder/internal/utils/utils.go +++ b/arduino/builder/internal/utils/utils.go @@ -20,7 +20,6 @@ import ( "strings" "unicode" - "github.com/arduino/arduino-cli/i18n" f "github.com/arduino/arduino-cli/internal/algorithms" "github.com/arduino/go-paths-helper" "github.com/pkg/errors" @@ -30,8 +29,6 @@ import ( "golang.org/x/text/unicode/norm" ) -var tr = i18n.Tr - // ObjFileIsUpToDate fixdoc func ObjFileIsUpToDate(sourceFile, objectFile, dependencyFile *paths.Path) (bool, error) { logrus.Debugf("Checking previous results for %v (result = %v, dep = %v)", sourceFile, objectFile, dependencyFile)