From 538400d234297b10052101e1f777e9732c3bd6c9 Mon Sep 17 00:00:00 2001 From: per1234 Date: Fri, 24 Jun 2022 07:37:15 -0700 Subject: [PATCH 1/2] [skip changelog] Revert "codecov: Disable pull request comments" This reverts commit 5c9eee348aa641a66f06605b416449b123baea0c. Codecov will now automatically comment on pull requests to provide a report of the code coverage impact that would result from the proposed changes. These comments are valuable for several reasons: - Brings test deficiencies to the contributor's attention - Encourages contributors to improve PRs that originally had insufficient test coverage for the added code - Facilitates the review process for the maintainers - Increases awareness of code coverage trends in the project (the Codecov website is great for this, but likely rarely visited) --- .codecov.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.codecov.yml b/.codecov.yml index e6977bea2f5..062ab589c79 100644 --- a/.codecov.yml +++ b/.codecov.yml @@ -1,5 +1,3 @@ -comment: off - ignore: - rpc/** - i18n/cmd/** From e00608a39600ef667c86c9aa57a25956b00796e3 Mon Sep 17 00:00:00 2001 From: per1234 Date: Fri, 24 Jun 2022 07:44:59 -0700 Subject: [PATCH 2/2] [skip changelog] Add support to "Test Go" workflow for alternative Codecov configuration paths For the sake of efficiency, the "Test Go" GitHub Actions workflow is configured to run only when relevant files are modified. Since the workflow uploads code coverage data to Codecov, the Codecov configuration file is one of these files. The standard filename for the Codecov configuration file is codecov.yml, and the workflow's path filter was configured for that filename. It turns out an alternative filename is also recognized: .codecov.yml, which is used by this project. Two subfolders are also supported in addition to the root of the repository as locations for the configuration file. The workflow's paths filter was not configured for the alternative filename and locations, meaning the workflow would not be triggered on change to the Codecov configuration in projects that use the alternative configuration file name or locations. The workflow's paths filter is hereby configured to recognize changes to any valid Codecov configuration file. --- .github/workflows/test-go-task.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-go-task.yml b/.github/workflows/test-go-task.yml index a35a74bed27..d8423d13b70 100644 --- a/.github/workflows/test-go-task.yml +++ b/.github/workflows/test-go-task.yml @@ -11,7 +11,9 @@ on: push: paths: - ".github/workflows/test-go-task.ya?ml" - - "codecov.ya?ml" + - ".github/.?codecov.ya?ml" + - "dev/.?codecov.ya?ml" + - ".?codecov.ya?ml" - "go.mod" - "go.sum" - "Taskfile.ya?ml" @@ -20,7 +22,9 @@ on: pull_request: paths: - ".github/workflows/test-go-task.ya?ml" - - "codecov.ya?ml" + - ".github/.?codecov.ya?ml" + - "dev/.?codecov.ya?ml" + - ".?codecov.ya?ml" - "go.mod" - "go.sum" - "Taskfile.ya?ml"