Simplified librariesmanager.Install

It does not require installLocation since it can be obtained with
libPath.Parent()

Author: cmaglie

arduino/libraries/librariesmanager/install.go

@@ -81,12 +81,8 @@ func (lm *LibrariesManager) InstallPrerequisiteCheck(indexLibrary *librariesinde
 }
 
 // Install installs a library on the specified path.
-func (lm *LibrariesManager) Install(indexLibrary *librariesindex.Release, libPath *paths.Path, installLocation libraries.LibraryLocation) error {
-	libsDir := lm.getLibrariesDir(installLocation)
-	if libsDir == nil {
-		return fmt.Errorf(tr("User directory not set"))
-	}
-	return indexLibrary.Resource.Install(lm.DownloadsDir, libsDir, libPath)
+func (lm *LibrariesManager) Install(indexLibrary *librariesindex.Release, libPath *paths.Path) error {
+	return indexLibrary.Resource.Install(lm.DownloadsDir, libPath.Parent(), libPath)
 }
 
 // Uninstall removes a Library

commands/lib/install.go

@@ -141,7 +141,7 @@ func installLibrary(lm *librariesmanager.LibrariesManager, libRelease *libraries
 		taskCB(&rpc.TaskProgress{Message: tr("Replacing %[1]s with %[2]s", libReplaced, libRelease)})
 	}
 
-	if err := lm.Install(libRelease, libPath, installLocation); err != nil {
+	if err := lm.Install(libRelease, libPath); err != nil {
 		return &arduino.FailedLibraryInstallError{Cause: err}
 	}
 	if libReplaced != nil && !libReplaced.InstallDir.EquivalentTo(libPath) {