Migrate TestCompileWithInvalidUrl from test_compile_part_2.py to compile_part_2_test.go

Author: MatteoPologruto

internal/integrationtest/compile/compile_part_2_test.go

@@ -150,3 +150,33 @@ func TestCompileWithCustomBuildPath(t *testing.T) {
 	require.NoFileExists(t, buildDir.Join(sketchName+".ino.with_bootloader.bin").String())
 	require.NoFileExists(t, buildDir.Join(sketchName+".ino.with_bootloader.hex").String())
 }
+
+func TestCompileWithInvalidUrl(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	// Init the environment explicitly
+	_, _, err := cli.Run("core", "update-index")
+	require.NoError(t, err)
+
+	// Download latest AVR
+	_, _, err = cli.Run("core", "install", "arduino:avr")
+	require.NoError(t, err)
+
+	sketchName := "CompileWithInvalidURL"
+	sketchPath := cli.SketchbookDir().Join(sketchName)
+	fqbn := "arduino:avr:uno"
+
+	// Create a test sketch
+	_, _, err = cli.Run("sketch", "new", sketchPath.String())
+	require.NoError(t, err)
+
+	_, _, err = cli.Run("config", "init", "--dest-dir", ".", "--additional-urls", "https://example.com/package_example_index.json")
+	require.NoError(t, err)
+
+	_, stderr, err := cli.Run("compile", "-b", fqbn, sketchPath.String())
+	require.NoError(t, err)
+	require.Contains(t, string(stderr), "Error initializing instance: Loading index file: loading json index file")
+	expectedIndexfile := cli.DataDir().Join("package_example_index.json")
+	require.Contains(t, string(stderr), "loading json index file "+expectedIndexfile.String()+": open "+expectedIndexfile.String()+":")
+}

test/test_compile_part_2.py

@@ -90,34 +90,6 @@ def test_compile_with_export_binaries_config(run_command, data_dir, downloads_di
     assert (sketch_path / "build" / fqbn.replace(":", ".") / f"{sketch_name}.ino.with_bootloader.hex").exists()
 
 
-def test_compile_with_invalid_url(run_command, data_dir):
-    # Init the environment explicitly
-    run_command(["core", "update-index"])
-
-    # Download latest AVR
-    run_command(["core", "install", "arduino:avr"])
-
-    sketch_name = "CompileWithInvalidURL"
-    sketch_path = Path(data_dir, sketch_name)
-    fqbn = "arduino:avr:uno"
-
-    # Create a test sketch
-    assert run_command(["sketch", "new", sketch_path])
-
-    # Create settings with custom invalid URL
-    assert run_command(
-        ["config", "init", "--dest-dir", ".", "--additional-urls", "https://example.com/package_example_index.json"]
-    )
-
-    # Verifies compilation fails cause of missing local index file
-    res = run_command(["compile", "-b", fqbn, sketch_path])
-    assert res.ok
-    lines = [l.strip() for l in res.stderr.splitlines()]
-    assert "Error initializing instance: Loading index file: loading json index file" in lines[0]
-    expected_index_file = Path(data_dir, "package_example_index.json")
-    assert f"loading json index file {expected_index_file}: " + f"open {expected_index_file}:" in lines[-1]
-
-
 def test_compile_with_custom_libraries(run_command, copy_sketch):
     # Creates config with additional URL to install necessary core
     url = "http://arduino.esp8266.com/stable/package_esp8266com_index.json"