Do not create overly verbose errors

cmaglie · cmaglie · commit 678dcd10f177 · 2022-09-22T17:44:36.000+02:00
diff --git a/arduino/cores/packagemanager/download.go b/arduino/cores/packagemanager/download.go
@@ -127,12 +127,7 @@ func (pme *Explorer) DownloadToolRelease(tool *cores.ToolRelease, config *downlo
 			Message: tr("Error downloading tool %s", tool),
 			Cause:   errors.New(tr("no versions available for the current OS"))}
 	}
-	if err := resource.Download(pme.DownloadDir, config, tool.String(), progressCB); err != nil {
-		return &arduino.FailedDownloadError{
-			Message: tr("Error downloading tool %s", tool),
-			Cause:   err}
-	}
-	return nil
+	return resource.Download(pme.DownloadDir, config, tool.String(), progressCB)
 }
 
 // DownloadPlatformRelease downloads a PlatformRelease. If the platform is already downloaded a

Original file line number	Diff line number	Diff line change
`@@ -127,12 +127,7 @@ func (pme Explorer) DownloadToolRelease(tool cores.ToolRelease, config *downlo`
`127`	`127`	`Message: tr("Error downloading tool %s", tool),`
`128`	`128`	`Cause: errors.New(tr("no versions available for the current OS"))}`
`129`	`129`	`}`
`130`		`- if err := resource.Download(pme.DownloadDir, config, tool.String(), progressCB); err != nil {`
`131`		`- return &arduino.FailedDownloadError{`
`132`		`- Message: tr("Error downloading tool %s", tool),`
`133`		`- Cause: err}`
`134`		`- }`
`135`		`- return nil`
	`130`	`+ return resource.Download(pme.DownloadDir, config, tool.String(), progressCB)`
`136`	`131`	`}`
`137`	`132`
`138`	`133`	`// DownloadPlatformRelease downloads a PlatformRelease. If the platform is already downloaded a`