From 92f18f6cf16edccdd8c0e8a1305df659a5da4e0a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lu=C3=ADs=20Ferreira?= Date: Mon, 28 Oct 2019 18:05:44 +0000 Subject: [PATCH 1/3] fix: Safe check to avoid OverflowException MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This checks the division by zero before converting into Int32. Signed-off-by: Luís Ferreira --- src/Models/Result/CodacyReport.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Models/Result/CodacyReport.cs b/src/Models/Result/CodacyReport.cs index 9abcb5e..2521602 100644 --- a/src/Models/Result/CodacyReport.cs +++ b/src/Models/Result/CodacyReport.cs @@ -25,7 +25,7 @@ public CodacyReport(IEnumerable fileReports) .Aggregate((Covered: 0, Total: 0), (t, n) => t = (Covered: t.Covered + n.Covered, Total: t.Total + n.Total)); - Total = Convert.ToInt32(Math.Round((double) totalTuple.Covered / totalTuple.Total * 100)); + Total = Convert.ToInt32((totalTuple.Total == 0) ? 0.0 : Math.Round((double) totalTuple.Covered / totalTuple.Total * 100)); FileReports = fileReports; } From ee42692ff931a7a0a6127cd8e0664e8ae210c3f1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lu=C3=ADs=20Ferreira?= Date: Mon, 28 Oct 2019 18:14:47 +0000 Subject: [PATCH 2/3] Add dotcover warning message when there's no File elements MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Luís Ferreira --- src/Parsing/Processors/DotCoverProcessor.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Parsing/Processors/DotCoverProcessor.cs b/src/Parsing/Processors/DotCoverProcessor.cs index 5dfb5c2..4b028f7 100644 --- a/src/Parsing/Processors/DotCoverProcessor.cs +++ b/src/Parsing/Processors/DotCoverProcessor.cs @@ -26,6 +26,10 @@ public Report Parse(string file) modules.Elements("File")) }; + if (report.FilesList.Count == 0) { + Console.WriteLine ("Warning: Got a report without File elements. Consider report dotCover with --ReportType=DetailedXML"); + } + foreach (var module in namespaces) { var classes = module.Elements("Type"); From d9c3f365d54361adebd771e181f3a414d2e00230 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lu=C3=ADs=20Ferreira?= Date: Mon, 28 Oct 2019 18:16:27 +0000 Subject: [PATCH 3/3] Update packages lock file MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Luís Ferreira --- test/CSharpCoverage.Tests/packages.lock.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/CSharpCoverage.Tests/packages.lock.json b/test/CSharpCoverage.Tests/packages.lock.json index 6a7ee1a..632c5de 100644 --- a/test/CSharpCoverage.Tests/packages.lock.json +++ b/test/CSharpCoverage.Tests/packages.lock.json @@ -875,7 +875,7 @@ "xunit.extensibility.core": "[2.4.1]" } }, - "codacy.csharpcoverage": { + "Codacy.CSharpCoverage": { "type": "Project", "dependencies": { "CommandLineParser": "2.5.0",