[Fix] OAS-10643 Update Error Codes (#675)

* Updated Error Codes for V2

* Updated error codes for v1

* Update Go Toolkit

* Update config

* Updated GoToolChain

* Add Go Tool Chain to v2 tests as well

* Downgrade toolchain to 1.23

Author: enikon

.circleci/config.yml

@@ -19,13 +19,13 @@ aliases:
 parameters:
   goImage:
     type: string
-    default: "gcr.io/gcr-for-testing/golang:1.22.6"
+    default: "gcr.io/gcr-for-testing/golang:1.22.12"
   arangodbImage:
     type: string
     default: "gcr.io/gcr-for-testing/arangodb/enterprise-preview:devel-nightly"
   alpineImage:
     type: string
-    default: "gcr.io/gcr-for-testing/alpine:3.17"
+    default: "gcr.io/gcr-for-testing/alpine:3.21"
   starterImage:
     type: string
     default: "arangodb/arangodb-starter:latest"

Makefile

@@ -5,6 +5,7 @@ CURR=$(shell dirname $(realpath $(lastword $(MAKEFILE_LIST))))
 ROOTDIR:=$(CURR)
 
 GOVERSION ?= 1.22.12
+GOTOOLCHAIN ?= go1.23.0
 GOIMAGE ?= golang:$(GOVERSION)
 GOV2IMAGE ?= $(GOIMAGE)
 ALPINE_IMAGE ?= alpine:3.17
@@ -186,6 +187,7 @@ run-unit-tests: run-v2-unit-tests
 		--rm \
 		-v "${ROOTDIR}":/usr/code \
 		-e CGO_ENABLED=$(CGO_ENABLED) \
+		-e GOTOOLCHAIN=$(GOTOOLCHAIN) \
 		-w /usr/code/ \
 		$(GOIMAGE) \
 		go test $(TESTOPTIONS) $(REPOPATH) $(REPOPATH)/http $(REPOPATH)/agency $(REPOPATH)/vst/protocol
@@ -195,6 +197,7 @@ run-v2-unit-tests:
 		--rm \
 		-v "${ROOTDIR}"/v2:/usr/code \
 		-e CGO_ENABLED=$(CGO_ENABLED) \
+		-e GOTOOLCHAIN=$(GOTOOLCHAIN) \
 		-w /usr/code/ \
 		$(GOIMAGE) \
 		go test $(TESTOPTIONS) $(REPOPATH)/v2/connection $(REPOPATH)/v2/arangodb/...
@@ -420,7 +423,8 @@ COMMON_DOCKER_CMD_PARAMS = \
 	-e TEST_ENABLE_SHUTDOWN=$(TEST_ENABLE_SHUTDOWN) \
 	-e ENABLE_DATABASE_EXTRA_FEATURES=$(ENABLE_DATABASE_EXTRA_FEATURES) \
 	-e GODEBUG=tls13=1 \
-	-e CGO_ENABLED=$(CGO_ENABLED)
+	-e CGO_ENABLED=$(CGO_ENABLED) \
+	-e GOTOOLCHAIN=$(GOTOOLCHAIN)
 
 
 # Internal test tasks

client_impl.go

@@ -85,7 +85,7 @@ func (c *client) SynchronizeEndpoints2(ctx context.Context, dbname string) error
 	cep, err := c.clusterEndpoints(ctx, dbname)
 	if err != nil {
 		// ignore Forbidden: automatic failover is not enabled errors
-		if !IsArangoErrorWithErrorNum(err, ErrHttpForbidden, ErrHttpInternal, 0, ErrNotImplemented, ErrForbidden) {
+		if !IsArangoErrorWithErrorNum(err, ErrHttpForbidden, ErrHttpNotImplemented, 0, ErrNotImplemented, ErrForbidden) {
 			// 3.2 returns no error code, thus check for 0
 			// 501 with ErrorNum 9 is in there since 3.7, earlier versions returned 403 and ErrorNum 11.
 			return WithStack(err)