=test #575 harden test_clusterReceptionist_shouldRemoveActorsOfTerminatedN… #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atedNodeFromListings_onNodeCrash
ktoso
commented
Jun 17, 2020
|
|
||
| // crash the second node | ||
| second.shutdown() | ||
| second.shutdown().wait() |
Member
Author
There was a problem hiding this comment.
makes the waiting for the down -> removal from reception a bit less racy
Member
Author
|
Our good pal |
Member
Author
|
Addressing in #683 |
ktoso
deleted the
test_clusterReceptionist_shouldRemoveActorsOfTerminatedNodeFromListings_onNodeCrash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like only a timing issue, could not spot anything very wrong in logs, esp after the latest reworks in cluster.
Let's see tho.
Resolves #575