Moves contract name to module constant in deploy scripts

acenolaza · acenolaza · commit 9a737e6cd62f · 2025-05-27T17:52:40.000-03:00
diff --git a/deploy/001_deploy_InverseApi3ReaderProxyV1.ts b/deploy/001_deploy_InverseApi3ReaderProxyV1.ts
@@ -2,7 +2,7 @@ import type { HardhatRuntimeEnvironment } from 'hardhat/types';
 
 import { getDeploymentName } from '../src';
 
-const VERIFICATION_BLOCK_CONFIRMATIONS = 5;
+export const CONTRACT_NAME = 'InverseApi3ReaderProxyV1';
 
 module.exports = async (hre: HardhatRuntimeEnvironment) => {
   const { getUnnamedAccounts, deployments, ethers, network, run } = hre;
@@ -25,18 +25,17 @@ module.exports = async (hre: HardhatRuntimeEnvironment) => {
 
   const isLocalNetwork = network.name === 'hardhat' || network.name === 'localhost';
 
-  const confirmations = isLocalNetwork ? 1 : VERIFICATION_BLOCK_CONFIRMATIONS;
+  const confirmations = isLocalNetwork ? 1 : 5;
   log(`Deployment confirmations: ${confirmations}`);
 
-  const contractName = 'InverseApi3ReaderProxyV1';
   const constructorArgs = [proxyAddress];
   const constructorArgTypes = ['address'];
 
-  const deploymentName = getDeploymentName(contractName, constructorArgTypes, constructorArgs);
+  const deploymentName = getDeploymentName(CONTRACT_NAME, constructorArgTypes, constructorArgs);
   log(`Generated deterministic deployment name for this instance: ${deploymentName}`);
 
   const deployment = await deploy(deploymentName, {
-    contract: contractName,
+    contract: CONTRACT_NAME,
     from: deployerAddress,
     args: constructorArgs,
     log: true,
@@ -49,11 +48,11 @@ module.exports = async (hre: HardhatRuntimeEnvironment) => {
   }
 
   log(
-    `Attempting verification of ${deploymentName} (contract type ${contractName}) at ${deployment.address} (already waited for confirmations)...`
+    `Attempting verification of ${deploymentName} (contract type ${CONTRACT_NAME}) at ${deployment.address} (already waited for confirmations)...`
   );
   await run('verify:verify', {
     address: deployment.address,
     constructorArguments: deployment.args,
   });
 };
-module.exports.tags = ['InverseApi3ReaderProxyV1'];
+module.exports.tags = [CONTRACT_NAME];
diff --git a/deploy/002_deploy_NormalizedApi3ReaderProxyV1.ts b/deploy/002_deploy_NormalizedApi3ReaderProxyV1.ts
@@ -1,10 +1,10 @@
 import type { HardhatRuntimeEnvironment } from 'hardhat/types';
 import type { DeploymentsExtension } from 'hardhat-deploy/types';
 
-const VERIFICATION_BLOCK_CONFIRMATIONS = 5;
-
 import { getDeploymentName } from '../src';
 
+export const CONTRACT_NAME = 'NormalizedApi3ReaderProxyV1';
+
 const deployTestFeed = async (deployments: DeploymentsExtension, deployerAddress: string) => {
   const { address: scaledApi3FeedProxyV1Address } = await deployments.get('ScaledApi3FeedProxyV1').catch(async () => {
     return deployments.deploy('ScaledApi3FeedProxyV1', {
@@ -40,18 +40,17 @@ module.exports = async (hre: HardhatRuntimeEnvironment) => {
 
   const isLocalNetwork = network.name === 'hardhat' || network.name === 'localhost';
 
-  const confirmations = isLocalNetwork ? 1 : VERIFICATION_BLOCK_CONFIRMATIONS;
+  const confirmations = isLocalNetwork ? 1 : 5;
   log(`Deployment confirmations: ${confirmations}`);
 
-  const contractName = 'NormalizedApi3ReaderProxyV1';
   const constructorArgs = [feedAddress];
   const constructorArgTypes = ['address'];
 
-  const deploymentName = getDeploymentName(contractName, constructorArgTypes, constructorArgs);
+  const deploymentName = getDeploymentName(CONTRACT_NAME, constructorArgTypes, constructorArgs);
   log(`Generated deterministic deployment name for this instance: ${deploymentName}`);
 
   const deployment = await deploy(deploymentName, {
-    contract: contractName,
+    contract: CONTRACT_NAME,
     from: deployerAddress,
     args: constructorArgs,
     log: true,
@@ -64,11 +63,11 @@ module.exports = async (hre: HardhatRuntimeEnvironment) => {
   }
 
   log(
-    `Attempting verification of ${deploymentName} (contract type ${contractName}) at ${deployment.address} (already waited for confirmations)...`
+    `Attempting verification of ${deploymentName} (contract type ${CONTRACT_NAME}) at ${deployment.address} (already waited for confirmations)...`
   );
   await run('verify:verify', {
     address: deployment.address,
     constructorArguments: deployment.args,
   });
 };
-module.exports.tags = ['NormalizedApi3ReaderProxyV1'];
+module.exports.tags = [CONTRACT_NAME];
diff --git a/deploy/003_deploy_ProductApi3ReaderProxyV1.ts b/deploy/003_deploy_ProductApi3ReaderProxyV1.ts
@@ -2,7 +2,7 @@ import type { HardhatRuntimeEnvironment } from 'hardhat/types';
 
 import { getDeploymentName } from '../src';
 
-const VERIFICATION_BLOCK_CONFIRMATIONS = 5;
+export const CONTRACT_NAME = 'ProductApi3ReaderProxyV1';
 
 module.exports = async (hre: HardhatRuntimeEnvironment) => {
   const { getUnnamedAccounts, deployments, ethers, network, run } = hre;
@@ -34,18 +34,17 @@ module.exports = async (hre: HardhatRuntimeEnvironment) => {
 
   const isLocalNetwork = network.name === 'hardhat' || network.name === 'localhost';
 
-  const confirmations = isLocalNetwork ? 1 : VERIFICATION_BLOCK_CONFIRMATIONS;
+  const confirmations = isLocalNetwork ? 1 : 5;
   log(`Deployment confirmations: ${confirmations}`);
 
-  const contractName = 'ProductApi3ReaderProxyV1';
   const constructorArgs = [proxy1Address, proxy2Address];
   const constructorArgTypes = ['address', 'address'];
 
-  const deploymentName = getDeploymentName(contractName, constructorArgTypes, constructorArgs);
+  const deploymentName = getDeploymentName(CONTRACT_NAME, constructorArgTypes, constructorArgs);
   log(`Generated deterministic deployment name for this instance: ${deploymentName}`);
 
   const deployment = await deploy(deploymentName, {
-    contract: contractName,
+    contract: CONTRACT_NAME,
     from: deployerAddress,
     args: constructorArgs,
     log: true,
@@ -58,11 +57,11 @@ module.exports = async (hre: HardhatRuntimeEnvironment) => {
   }
 
   log(
-    `Attempting verification of ${deploymentName} (contract type ${contractName}) at ${deployment.address} (already waited for confirmations)...`
+    `Attempting verification of ${deploymentName} (contract type ${CONTRACT_NAME}) at ${deployment.address} (already waited for confirmations)...`
   );
   await run('verify:verify', {
     address: deployment.address,
     constructorArguments: deployment.args,
   });
 };
-module.exports.tags = ['ProductApi3ReaderProxyV1'];
+module.exports.tags = [CONTRACT_NAME];
diff --git a/deploy/004_deploy_ScaledApi3FeedProxyV1.ts b/deploy/004_deploy_ScaledApi3FeedProxyV1.ts
@@ -1,10 +1,10 @@
 import type { HardhatRuntimeEnvironment } from 'hardhat/types';
 import type { DeploymentsExtension } from 'hardhat-deploy/types';
 
-const VERIFICATION_BLOCK_CONFIRMATIONS = 5;
-
 import { getDeploymentName } from '../src';
 
+export const CONTRACT_NAME = 'ScaledApi3FeedProxyV1';
+
 const deployTestProxy = async (deployments: DeploymentsExtension, deployerAddress: string) => {
   const { address: inverseApi3ReaderProxyV1Address } = await deployments
     .get('InverseApi3ReaderProxyV1')
@@ -46,18 +46,17 @@ module.exports = async (hre: HardhatRuntimeEnvironment) => {
 
   const isLocalNetwork = network.name === 'hardhat' || network.name === 'localhost';
 
-  const confirmations = isLocalNetwork ? 1 : VERIFICATION_BLOCK_CONFIRMATIONS;
+  const confirmations = isLocalNetwork ? 1 : 5;
   log(`Deployment confirmations: ${confirmations}`);
 
-  const contractName = 'ScaledApi3FeedProxyV1';
   const constructorArgs = [proxyAddress, decimals];
   const constructorArgTypes = ['address', 'uint8'];
 
-  const deploymentName = getDeploymentName(contractName, constructorArgTypes, constructorArgs);
+  const deploymentName = getDeploymentName(CONTRACT_NAME, constructorArgTypes, constructorArgs);
   log(`Generated deterministic deployment name for this instance: ${deploymentName}`);
 
   const deployment = await deploy(deploymentName, {
-    contract: contractName,
+    contract: CONTRACT_NAME,
     from: deployerAddress,
     args: constructorArgs,
     log: true,
@@ -70,11 +69,11 @@ module.exports = async (hre: HardhatRuntimeEnvironment) => {
   }
 
   log(
-    `Attempting verification of ${deploymentName} (contract type ${contractName}) at ${deployment.address} (already waited for confirmations)...`
+    `Attempting verification of ${deploymentName} (contract type ${CONTRACT_NAME}) at ${deployment.address} (already waited for confirmations)...`
   );
   await run('verify:verify', {
     address: deployment.address,
     constructorArguments: deployment.args,
   });
 };
-module.exports.tags = ['ScaledApi3FeedProxyV1'];
+module.exports.tags = [CONTRACT_NAME];
