Apply "static_lambda" CS rule under src/ dir
#3725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
phansys
commented
Sep 15, 2020
phansys
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tickets | n/a |
| License | MIT |
| Doc PR | n/a |
phansys
force-pushed
the
cs_rules
branch
2 times, most recently
from
0c89e06 to
5dda0b6
Compare
phansys
changed the title
src/ dir
Member
|
thoughts @api-platform/core-team ? |
Member
|
I'm OK for this. Is there any CS rule to add it automatically? |
vincentchalamon
approved these changes
Nov 8, 2020
Contributor
vincentchalamon
left a comment
vincentchalamon
left a comment
There was a problem hiding this comment.
I agree with @alanpoulain, it would be perfect with a php-cs rule
Contributor
Author
|
Sorry for the delay. If the rule is added, there are some cases where the replacement is invalid (I think in cases where the function is used for binding purposes). |
Member
|
Please rebase then :) and we'll fix this on 2.5 |
phansys
force-pushed
the
cs_rules
branch
2 times, most recently
from
5ac6ba0 to
587211e
Compare
Member
|
Can you target 2.5 please ? |
Contributor
Author
Done. |
Member
|
Thanks @phansys ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.