Get resource from parent #2760

vincentchalamon · 2019-04-24T08:24:56Z

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#2759
License	MIT

Check for parent ApiResource in RouteNameResolver
Update unit tests
Remove unfinished behat test features/graphql/non_resource.feature (false-positive in CI)
Add non-regression behat tests

bendavies · 2019-04-24T09:32:00Z

I think maybe adding to https://github.com/api-platform/core/blob/master/features/main/table_inheritance.feature is appropriate here?

Edit: maybe not that feature, but at least a new functional test.

vincentchalamon · 2019-04-24T09:36:02Z

@bendavies This PR is still in WIP, but yes I'll definitively add new behat tests 👍

bendavies · 2019-04-24T09:37:18Z

@bendavies This PR is still in WIP, but yes I'll definitively add new behat tests 👍

hah ok :) all your checkboxes were done so i thought it was complete :)

vincentchalamon · 2019-04-24T09:38:29Z

The main part of this PR is done, now it's time to add some non-regressions tests :)

vincentchalamon · 2019-04-24T09:40:34Z

I think maybe adding to https://github.com/api-platform/core/blob/master/features/main/table_inheritance.feature is appropriate here?

Edit: maybe not that feature, but at least a new functional test.

I think it should be the best place indeed. Thanks for it :)

features/graphql/non_resource.feature

src/Bridge/Symfony/Routing/RouteNameResolver.php

@vincentchalamon

Previous commits fix the behavior with non api resources inherited from resource but relation management was still not ok since the update was not done on the abstract item normalizer. The resource class resolver is now used as it should in every normalizers. Most of this commit (tests) comes from @vincentchalamon and its PR api-platform#2760

@vincentchalamon

Previous commits fix the behavior with non api resources inherited from resource but relation management was still not ok since the update was not done on the abstract item normalizer. The resource class resolver is now used as it should in every normalizers. Most of this commit (tests) comes from @vincentchalamon and its PR api-platform#2760

@vincentchalamon

Previous commits fix the behavior with non api resources inherited from resource but relation management was still not ok since the update was not done on the abstract item normalizer. The resource class resolver is now used as it should in every normalizers. Most of this commit (tests) comes from @vincentchalamon and its PR api-platform#2760

antograssiot · 2019-04-24T15:48:15Z

features/main/table_inheritance.feature

+
+  @!mongodb
+  @createSchema
+  @dropSchema


This doesn't exists anymore IIRC

antograssiot · 2019-04-29T04:33:19Z

features/main/table_inheritance.feature

+                "pattern": "^/custom_users/\\d+$",
+                "required": "true"
+              }
+            }


Suggested change

}

},

"additionalProperties": false

antograssiot · 2019-04-29T04:33:48Z

features/main/table_inheritance.feature

+                "pattern": "^/external_users/\\d+$",
+                "required": "true"
+              }
+            }


Suggested change

}

},

"additionalProperties": false

antograssiot · 2019-04-29T04:44:49Z

src/Bridge/Symfony/Routing/RouteNameResolver.php

+            $operation = $route->getDefault(sprintf('_api_%s_operation_name', $operationType));
+            $methods = $route->getMethods();
+
+            if (null !== $operation && (empty($methods) || \in_array('GET', $methods, true)) && null !== $currentResourceClass && is_a($resourceClass, $currentResourceClass, true)) {


Just asking but maybe we could add this if statement in the previous loop and saved the first value found that would be returned at the after the loop if not null to avoid looping through all routes twice here ?

vincentchalamon · 2019-04-29T06:58:19Z

Closing in favor of #2714

@vincentchalamon

Previous commits fix the behavior with non api resources inherited from resource but relation management was still not ok since the update was not done on the abstract item normalizer. The resource class resolver is now used as it should in every normalizers. Most of this commit (tests) comes from @vincentchalamon and its PR api-platform#2760

@vincentchalamon

Previous commits fix the behavior with non api resources inherited from resource but relation management was still not ok since the update was not done on the abstract item normalizer. The resource class resolver is now used as it should in every normalizers. Most of this commit (tests) comes from @vincentchalamon and its PR api-platform#2760

@vincentchalamon

Previous commits fix the behavior with non api resources inherited from resource but relation management was still not ok since the update was not done on the abstract item normalizer. The resource class resolver is now used as it should in every normalizers. Most of this commit (tests) comes from @vincentchalamon and its PR api-platform#2760

@vincentchalamon

Previous commits fix the behavior with non api resources inherited from resource but relation management was still not ok since the update was not done on the abstract item normalizer. The resource class resolver is now used as it should in every normalizers. Most of this commit (tests) comes from @vincentchalamon and its PR api-platform#2760

@vincentchalamon

Previous commits fix the behavior with non api resources inherited from resource but relation management was still not ok since the update was not done on the abstract item normalizer. The resource class resolver is now used as it should in every normalizers. Most of this commit (tests) comes from @vincentchalamon and its PR api-platform#2760

teohhanhui · 2019-05-20T14:37:16Z

See #2797 instead.

vincentchalamon added bug [WIP] Work In Progress labels Apr 24, 2019

vincentchalamon self-assigned this Apr 24, 2019

vincentchalamon force-pushed the issue/resource-inheritance branch 4 times, most recently from 4eeea0d to dd9d48a Compare April 24, 2019 09:25

vincentchalamon changed the title ~~Issue/resource inheritance~~ Get resource from parent Apr 24, 2019

vincentchalamon force-pushed the issue/resource-inheritance branch from dd9d48a to fce9c71 Compare April 24, 2019 10:07

vincentchalamon added [RFR] Ready for Review and removed [WIP] Work In Progress labels Apr 24, 2019

vincentchalamon requested review from alanpoulain, dunglas and soyuka April 24, 2019 10:08

vincentchalamon force-pushed the issue/resource-inheritance branch from fce9c71 to f96cbc4 Compare April 24, 2019 10:09

soyuka reviewed Apr 24, 2019

View reviewed changes

features/graphql/non_resource.feature Show resolved Hide resolved

src/Bridge/Symfony/Routing/RouteNameResolver.php Outdated Show resolved Hide resolved

Fix api-platform#2759

ba95062

vincentchalamon force-pushed the issue/resource-inheritance branch from f96cbc4 to ba95062 Compare April 24, 2019 10:19

vincentchalamon requested a review from soyuka April 24, 2019 10:20

vincentchalamon force-pushed the issue/resource-inheritance branch 3 times, most recently from ce6e679 to ab8de31 Compare April 24, 2019 12:00

Fix review

07adbde

vincentchalamon force-pushed the issue/resource-inheritance branch from ab8de31 to 07adbde Compare April 24, 2019 12:58

vincentchalamon mentioned this pull request Apr 24, 2019

"No item route associated with the type" exception using class inheritance #2759

Closed

antograssiot reviewed Apr 29, 2019

View reviewed changes

vincentchalamon closed this Apr 29, 2019

vincentchalamon deleted the issue/resource-inheritance branch June 11, 2021 06:56

Uh oh!

Get resource from parent #2760

Get resource from parent #2760

Uh oh!

Conversation

vincentchalamon commented Apr 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bendavies commented Apr 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vincentchalamon commented Apr 24, 2019

Uh oh!

bendavies commented Apr 24, 2019

Uh oh!

vincentchalamon commented Apr 24, 2019

Uh oh!

vincentchalamon commented Apr 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

antograssiot Apr 24, 2019

Choose a reason for hiding this comment

Uh oh!

antograssiot Apr 29, 2019

Choose a reason for hiding this comment

Uh oh!

antograssiot Apr 29, 2019

Choose a reason for hiding this comment

Uh oh!

antograssiot Apr 29, 2019

Choose a reason for hiding this comment

Uh oh!

vincentchalamon commented Apr 29, 2019

Uh oh!

teohhanhui commented May 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vincentchalamon commented Apr 24, 2019 •

edited

Loading

bendavies commented Apr 24, 2019 •

edited

Loading

vincentchalamon commented Apr 24, 2019 •

edited

Loading